-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDTensors] Add DiagonalArrays
submodule
#1225
Conversation
…rs.jl into NDTensors_arraytensor_ops
…rs.jl into NDTensors_arraytensor_ops
…rs.jl into NDTensors_arraytensor_ops
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
===========================================
- Coverage 85.37% 67.21% -18.17%
===========================================
Files 89 88 -1
Lines 8453 8415 -38
===========================================
- Hits 7217 5656 -1561
- Misses 1236 2759 +1523 ☔ View full report in Codecov by Sentry. |
Description
Adds a
DiagonalArrays
submodule, which defines a typeDiagonalArray
which generalizesLinearAlgebra.Diagonal
to n-dimensional arrays.This follows up on efforts in #1206, #1205, #1222, and #1213 to replace the
TensorStorage
subtypesDense
,Diag
,BlockSparse
, andDiagBlockSparse
with Julia AbstractArrays. So far this just implemented basicAbstractArray
interface functions but not the functions needed for it to be used as an ITensor backend, that will be left for future work.@kmp5VT @emstoudenmire
This is branched off of #1222 so I won't merge this until that is merged.