Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDTensors] Add DiagonalArrays submodule #1225

Merged
merged 24 commits into from
Oct 30, 2023
Merged

Conversation

mtfishman
Copy link
Member

Description

Adds a DiagonalArrays submodule, which defines a type DiagonalArray which generalizes LinearAlgebra.Diagonal to n-dimensional arrays.

This follows up on efforts in #1206, #1205, #1222, and #1213 to replace the TensorStorage subtypes Dense, Diag, BlockSparse, and DiagBlockSparse with Julia AbstractArrays. So far this just implemented basic AbstractArray interface functions but not the functions needed for it to be used as an ITensor backend, that will be left for future work.

@kmp5VT @emstoudenmire

This is branched off of #1222 so I won't merge this until that is merged.

mtfishman and others added 21 commits October 27, 2023 09:06
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
NDTensors/src/DiagonalArrays/examples/README.jl Outdated Show resolved Hide resolved
NDTensors/src/DiagonalArrays/src/DiagonalArrays.jl Outdated Show resolved Hide resolved
NDTensors/src/DiagonalArrays/src/DiagonalArrays.jl Outdated Show resolved Hide resolved
NDTensors/src/DiagonalArrays/src/DiagonalArrays.jl Outdated Show resolved Hide resolved
NDTensors/src/DiagonalArrays/src/DiagonalArrays.jl Outdated Show resolved Hide resolved
NDTensors/src/DiagonalArrays/src/diagview.jl Outdated Show resolved Hide resolved
NDTensors/src/DiagonalArrays/src/diagview.jl Outdated Show resolved Hide resolved
NDTensors/src/DiagonalArrays/test/runtests.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (690b219) 85.37% compared to head (78a0bad) 67.21%.

❗ Current head 78a0bad differs from pull request most recent head 9c457d9. Consider uploading reports for the commit 9c457d9 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1225       +/-   ##
===========================================
- Coverage   85.37%   67.21%   -18.17%     
===========================================
  Files          89       88        -1     
  Lines        8453     8415       -38     
===========================================
- Hits         7217     5656     -1561     
- Misses       1236     2759     +1523     

see 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman merged commit c8664bf into main Oct 30, 2023
7 checks passed
@mtfishman mtfishman deleted the NDTensors_diagonalarray branch October 30, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants