-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDTensors] Add StridedViews dependency and fix using statement #1238
Conversation
That's strange, I don't understand why the current code would have been failing. For example this works: julia> using Strided.StridedViews
julia> StridedView(@view randn(4, 4)'[1:2, 1:2])
2×2 StridedView{Float64, 2, Matrix{Float64}, typeof(identity)}:
-0.501281 -0.0232372
0.00611145 1.82511 i.e. it's fine to load a dependency of a package in that way, even if it is a separate package. I'm not against this change since it's reasonable to make use of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1238 +/- ##
===========================================
- Coverage 85.35% 54.56% -30.79%
===========================================
Files 89 88 -1
Lines 8445 8392 -53
===========================================
- Hits 7208 4579 -2629
- Misses 1237 3813 +2576 ☔ View full report in Codecov by Sentry. |
Helpful to know. I was interpreting the notation Sure enough, my If you prefer this change, please go ahead and merge or I can but if not we can close this PR. |
Could you add a compat entry of |
Great. I modified the following lines of NDTensors Project.toml:
Please let me know if you think it'd be better to put, say, 2.0.4 for Strided or any other change like that. (The line about Requires was just something the Julia package manager did when I added StridedViews through the REPL.) |
Description
Before this change, NDTensors was failing to precompile. This was after making sure I had updated various dependencies and taken both NDTensors and ITensors out of 'dev' mode as checks that it wasn't for any of these reasons.
It seems that StridedViews.jl is now its own separate package, so no longer inside of the latest version of Strided.jl (see this comment in the What's New section of Strided.jl's README). This PR adds StridedViews as a dependency and does
using StridedViews
directly instead of the previous code doingusing Strided.StridedViews
.