-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDTensors] Some fixes for element type promotion and conversion #1244
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1244 +/- ##
===========================================
- Coverage 85.44% 54.81% -30.63%
===========================================
Files 89 88 -1
Lines 8400 8348 -52
===========================================
- Hits 7177 4576 -2601
- Misses 1223 3772 +2549
☔ View full report in Codecov by Sentry. |
@kmp5VT so interestingly the new tests I added for block sparse DMRG pass on CPU and Metal (I checked locally) but seem to be failing with CUDA. |
That is interesting, I can look into what is going on later today! |
Thanks! I've marked the tests as broken for now so I can merge this fix. |
@kmp5VT I noticed some of the tests you wrote in #1236 used arrays with uninitialized memory (i.e. |
This fixes a few issues with element type promotion and conversion, such as mixed element type contractions of block sparse tensors on GPU as well as better element type preservation when the noise term is enabled in DMRG.
I also extended the new DMRG tests on GPU introduced in #1236 to the case of QN conservation/block sparse tensors, which pass locally for me using a Metal backend.