Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for AMDGPU in [weakdeps] to 1 for package NDTensors, (keep existing compat) #1522

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 9, 2024

This pull request changes the compat entry for the AMDGPU package from 0.9 to 0.9, 1 for package NDTensors.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-08-09-00-15-47-745-03196912800 branch from f2903e1 to ae6d183 Compare August 9, 2024 00:15
@mtfishman
Copy link
Member

@kmp5VT I don't have a way to test this but I'll assume that AMDGPU.jl v1 won't break anything for us since we are using pretty basic operations anyway.

Do you know if there has been any progress getting Jenkins CI running on AMD GPUs?

@mtfishman mtfishman merged commit cf51897 into main Sep 3, 2024
1 check passed
@mtfishman mtfishman deleted the compathelper/new_version/2024-08-09-00-15-47-745-03196912800 branch September 3, 2024 20:18
@kmp5VT
Copy link
Collaborator

kmp5VT commented Sep 3, 2024

@mtfishman, I can jump on the amdgpu here at FI and run the tests to verify that everything is okay. Last time I asked I was told that we are not able to run Jenkins CI on the AMD GPU's because there are such a limited number of GPU's available (we only have 3). But I can ask Dylan again

@kmp5VT
Copy link
Collaborator

kmp5VT commented Sep 4, 2024

@mtfishman I was able to try and run on the AMDGPU. I am seeing an issue that seems to be unrelated to the GPU and related to an issue with Linux and the LinearMaps.jl package. This is the error

Test /mnt/home/kpierce/.julia/dev/ITensors/NDTensors/test/test_blocksparse.jlPrecompiling:  Error During Testproject... at 
/mnt/home/kpierce/.julia/dev/ITensors/NDTensors/test/runtests.jl:13
  Got exception outside of a @test  Progress [>                                        ]  0/240
  LoadError: failed to find source of parent package: "LinearMaps"
  Progress [>                                        ]  0/240

I also find issues with LinearMaps on my workstation and have already opened this issue on their repo. I have found that if I constrain to a slightly lower version 3.1.1 then there is no issue compiling

@mtfishman
Copy link
Member

Interesting, thanks for checking, indeed it looks like that issue is unrelated to updating AMDGPU.jl to v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants