New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDTensors] [BUG] `similartype(::Diagonal)` returns `Vector` instead of `Matrix` #1566

Closed

mtfishman opened this issue Nov 5, 2024 · 0 comments · Fixed by #1570

Labels

Member

mtfishman commented Nov 5, 2024 •

edited

Loading

For example:

julia> using LinearAlgebra: Diagonal

julia> using NDTensors.TypeParameterAccessors: similartype

julia> similartype(Diagonal{Float64,Vector{Float64}})
Vector{Float64} (alias for Array{Float64, 1})

Hit this in #1560.

mtfishman added bug NDTensors labels

mtfishman mentioned this issue

[TypeParameterAccessors] Fix similartype(Diagonal), introduce similartype(Array, NDims(3)) #1570

Merged

mtfishman closed this as completed in #1570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment