Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with new package skeleton #4

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Conversation

lkdvos
Copy link
Contributor

@lkdvos lkdvos commented Dec 3, 2024

This PR provides an intermediate update for the ongoing work of getting a good package skeleton.

@lkdvos
Copy link
Contributor Author

lkdvos commented Dec 3, 2024

Small FYI that the codecov will continue complaining until a token is added to the secrets of the repository, and that has been properly set up. I don't have the rights to access this however.

@mtfishman
Copy link
Member

Small FYI that the codecov will continue complaining until a token is added to the secrets of the repository, and that has been properly set up. I don't have the rights to access this however.

How would I do that, and/or how would I give you access to do that?

@mtfishman
Copy link
Member

The CI.yml workflow needs to be deleted.

Copy link

codecov bot commented Dec 3, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@lkdvos lkdvos closed this Dec 3, 2024
@lkdvos lkdvos reopened this Dec 3, 2024
@lkdvos
Copy link
Contributor Author

lkdvos commented Dec 3, 2024

Ok, this seems to now have fixed the remaining issues with the codecov actions, and is ready to merge + register from my end.

@mtfishman mtfishman merged commit c095ef6 into ITensor:main Dec 3, 2024
19 checks passed
@lkdvos lkdvos deleted the registry branch December 4, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants