Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a box in ALCH00063.11 (Yahuda 259 bundle 11) #103

Open
aewingate opened this issue Mar 16, 2021 · 11 comments
Open

Creating a box in ALCH00063.11 (Yahuda 259 bundle 11) #103

aewingate opened this issue Mar 16, 2021 · 11 comments
Assignees
Labels
awaiting signoff Fix has been attempted and needs confirmation that it's done encoding TEI P5 encoding issues rendering Rendering of TEI markup

Comments

@aewingate
Copy link
Collaborator

On f. 11.1r of ALCH00063 (aka f. 1r of ALCH00063.11), Newton has a partial box to separate some information off from the main column of text on the left.
image
Currently we haven't encoded this box in either the current site or Carbon. We're just using <space> on each of the three lines to push the content over.
image

I have not included a screenshot of the source code since the four bibls and bibliographic notes make it kind of unwieldy to show, but if you download ALCH00063-11, it's lines 353-354 plus 358 (to get the "3" in the third line). If we can a box or other sort of container around the content, I think the "3" will have to move up in the encoding to be with the 4 citations in the first two lines of the box.

@aewingate aewingate added encoding TEI P5 encoding issues rendering Rendering of TEI markup labels Mar 16, 2021
@tubesoft
Copy link
Collaborator

tubesoft commented Mar 16, 2021

One choise would be applying double-column. You can code like this:

<div rend="parallel-docs">
    <div rend="parallel-left rule-right-side">
              Write here for left side
    </div>
    <div rend="parallel-right">
              Write here for right ride
    </div>
</div>

the attribute rend="rule-right-side" enables to rule the right side of the column.
Likewise, if you code rend="rule-left-side", you can rule the right side of the column.
Ruling the left side and upper side of the right column should make the column look like a box as we see in the manuscript.
However, for now, we cannot write rend="rule-upper-side" or rend="rule-bottom-side" because corresponding CSS code does not exist. Of course, I could add those CSS too if you decide to use double-column.

For double-column, you can also take a look at Babson417, though it is not rendered properly yet.

@aewingate
Copy link
Collaborator Author

If you can get the rend="rule-upper-side" to work, I think the double-column makes sense as a solution since I'm assuming we could just encode a small section as double columns.

Would it be possible to get the text inside the right column to be left aligned? I'm just thinking about that since looking at Bason417 the content in the right column seems to be right aligned. (Unless that's part of the rendering issue, in which case, nevermind!)

@tubesoft
Copy link
Collaborator

Ah, looking right-aligned is actually because we need to change the TEI code of Babson471. The headers of folios and thumbnail of the page images constitute another column. That is, the rendered page actually has three columns.

When the TEI code is corrected, it looks like this:
image

Also, if you apply the code like rend="w-35em", you can specify the width of the column so that the rendered page looks close to the manuscript. I assume you cannot preview rendering from Oxygen for P5 project, so I could adjust the width of column if you complete editing the file and give it to me.

@tubesoft
Copy link
Collaborator

tubesoft commented Apr 6, 2021

@aewingate, I am adding CSS code that is applied when you code rend="rule-top-side" and rend="rule-bottom-side" on TEI.
I decided to use "top" instead of "upper" since CSS usually uses the word "top".
Please send me the TEI code once you finish coding the file. I can check the rendering in my local environment.

@aewingate
Copy link
Collaborator Author

I've encountered a problem with the parallel-docs strategy. The section in question is encoded as a <list type="gloss"> with <item> children inside of it. Unfortunately, <div> can't be contained within <list> so I can't surround the <item> tags with <div rend="parallel-docs"> . I'm not quite sure how to proceed since it is clearly a list, and the encoding guide states that it should be encoded with <list>.

@tubesoft
Copy link
Collaborator

tubesoft commented Apr 12, 2021

I tried to end <list type="gross"> with </list> at the end of item "6.". And then, I composed parallel-doc divs. At the left column, I created <list type="gross"> and </list> again, between which I put item "E.", "7." and "B".
Right after the end of parallel-doc divs, I started <list type="gross"> again.

This is what I coded after line 7026 (of ALCH00063)

                     </list>
                     <div rend="parallel-docs">
                     <div rend="parallel-left">
                        <list type="gloss">
	                    <item>
	                        E <label>white <choice><abbr>sp<hi rend="super">t</hi></abbr><expan>spirit</expan></choice> of <g ref="#UNx1f716">🜖</g></label> <bibl default="false">p 155</bibl>
	                    </item>
	                    <item>
                                7 <space dim="horizontal" extent="3" quantity="3"/><label>Philosophick <g ref="#UNx1f70d">🜍</g> <add rend="caret" place="supralinear">or oyle</add></label> <bibl><abbr>Test</abbr> 155, <hi rend="u">161</hi></bibl> <lb/>
                                <space dim="horizontal" extent="7" quantity="7"/> It reduces white <g ref="#UNx2609">☉</g> to gold again<lb/><!-- This is in the section set off by lines. -->
                            </item>
                            <item>
                                B <label><add rend="caret" place="supralinear">Red</add> oyle of Vitriol</label> <bibl><abbr>Test</abbr> p <hi rend="u">161</hi> 167</bibl> <lb/>
                                <space dim="vertical" extent="1" quantity="1"/>
                            </item>
                        </list>
                     </div>
                     <div rend="parallel-right rule-left-side rule-top-side">
                        His Theory is described <choice><orig>j</orig><reg>1</reg></choice> in <bibl default="false">12 Keys</bibl>, <add place="supralinear">2</add> <bibl default="false">Elucidation </bibl><lb/>       <!-- N.B. There is a section here set off by horizontal and vertical lines that appears to be a comment, one not clearly linked to any list item. -->
                        <space dim="horizontal" extent="5" quantity="5"/> 3 <bibl default="false">Short way &amp; repetition</bibl>, 4, <bibl default="false"><abbr>Philos</abbr> <unclear reason="indistinct"><g ref="#UNx1f716">🜖</g></unclear><!-- Note hasty symbol. --> <g ref="#UNx1f70d">🜍</g> &amp; mg-</bibl> <lb/>
                        <space dim="vertical" extent="1" quantity="1"/> 3
                     </div>
                     </div>
                     <list type="gloss">

And, it shows like this:
image

@aewingate
Copy link
Collaborator Author

Okay that makes perfect sense! I'll encode that way and send you the file. Thanks!

@tubesoft
Copy link
Collaborator

After some collaborative work with @aewingate , we've got rendering like this:
image

@tubesoft tubesoft added the awaiting signoff Fix has been attempted and needs confirmation that it's done label Apr 26, 2021
tubesoft pushed a commit that referenced this issue May 25, 2021
@wehooper
Copy link
Collaborator

wehooper commented Jun 3, 2021

This issue cannot be closed until we rebuild the combined ALCH00063 document with part 11 included. The current version of the combined document dates from autumn 2020 and ALCH00063-11 cannot be viewed on the website until the combined document is rebuilt.

@mdalmau
Copy link
Collaborator

mdalmau commented Jun 8, 2021

@wehooper will update one of the parts that has parallel encoding (notes and comments) and the generate the whole document manually, upload to Xubmit and let Michelle know so she can re-index the new Newton site and merge latest changes.

@wehooper
Copy link
Collaborator

I have corrected the parallel columns in ALCH00063-07.xml and uploaded that to Xubmit. I also updated the TEIHeader in the template to include the correct resp statements, then built the new assembled version.

Neither the assembled document nor the template will validate under Xubmit's rules, so I have zipped copies of them and emailed copies to Michelle, Alex, and Takatomo. Michelle can access Xubmit from a command line.

When carbonate or possum are repopulated from Xubmit and reindexed on the website admin page, we will be able to check both the parallel columns in 63.07 and the box in 63.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting signoff Fix has been attempted and needs confirmation that it's done encoding TEI P5 encoding issues rendering Rendering of TEI markup
Projects
None yet
Development

No branches or pull requests

4 participants