Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Representing deletions in <note type="translation"> #131

Open
aewingate opened this issue Oct 3, 2023 · 2 comments
Open

Representing deletions in <note type="translation"> #131

aewingate opened this issue Oct 3, 2023 · 2 comments
Assignees
Labels
rendering Rendering of TEI markup

Comments

@aewingate
Copy link
Collaborator

We need a way to deal with the deleted text encoded in <note type="translation">. Currently, as seen below, the deleted text is printed normally despite being marked with <del rend="strike"> in the TEI.

image
TEI
image

The preferred result would be that this text was struck through in the pop-up in the diplomatic version and then removed in the normalized just as it works in the original untranslated manuscript.

If this isn't possible, deleting the text from both the diplomatic and normalized is the next best thing. This is also what currently happens on the P4 site.

@aewingate aewingate added the rendering Rendering of TEI markup label Oct 3, 2023
@tubesoft
Copy link
Collaborator

tubesoft commented Oct 7, 2023

Currently, the text of the pop-up is located in the @title of a <span> element (See below). Unless we change the type of pop-up into something like <bibl> or some other <note>, we cannot contain styled text. Or you can just modify the translation, like deleting the part or using some brackets. Which du you prefer?
image

@tubesoft
Copy link
Collaborator

I added a bibl-like popup. The cross-out is properly rendered.

image

tubesoft pushed a commit that referenced this issue Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rendering Rendering of TEI markup
Projects
None yet
Development

No branches or pull requests

2 participants