Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move internal event.Event model to pkg namespace #280

Open
UiP9AV6Y opened this issue Sep 21, 2024 · 0 comments
Open

Move internal event.Event model to pkg namespace #280

UiP9AV6Y opened this issue Sep 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@UiP9AV6Y
Copy link

Golang applications which want to create integration for the icinga-notifications event processing API (/process-event) currently need to maintain their own Event model implementation as the one this project provides is hidden in the internal/event namespace. ideally event.Event and event.Severity live in the pkg namespace (e.g. pkg/model) and the internal event.Event implementation can be rewritten to something like this

type Event struct {
	model.Event

	Time     time.Time
	SourceId int64
	ID       int64
}

this would follow to approach taken for the plugin system, where the models are public too (pkg/plugin)

@oxzi oxzi added the enhancement New feature or request label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants