로그인 페이지 퍼블리싱 #35
Merged
로그인 페이지 퍼블리싱 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logoutRequest와 RefreshToken Request를
gitignore파일에 baseURL 추가
URLInfo 제거
ViewController -> VC로 수정
로그인 페이지를 수정된 디자인에 맞게 퍼블리싱
Closed
baekteun
reviewed
Aug 8, 2023
.gitignore
Outdated
| @@ -1,4 +1,5 @@ | |||
| # Created by https://www.toptal.com/developers/gitignore/api/swiftpackagemanager,swift,xcode,macos,git | |||
|
|
|||
| 이# Created by https://www.toptal.com/developers/gitignore/api/swiftpackagemanager,swift,xcode,macos,git | |||
There was a problem hiding this comment.
반영했습니다.
baekteun
reviewed
Aug 8, 2023
| case logout(param: LogoutRequest) | ||
| case refreshToken(param: RefreshTokenRequest) | ||
| case logout(param: String) | ||
| case refreshToken(param: String) |
There was a problem hiding this comment.
param 이라는 이름은 의미가 너무 불명확한거같은데 더 의미를 붙여주는 이름으로 바꾸는거 어떤가요
There was a problem hiding this comment.
반영했습니다
uuuunseo
reviewed
Aug 8, 2023
| private lazy var loginButton = NextStepButton().then{ | ||
| $0.setTitle("로그인", for: .normal) | ||
| $0.isEnabled = false | ||
| $0.backgroundColor = UIColor(rgb: 0x999999) |
There was a problem hiding this comment.
backgroundColor는 PrimaryColor가 되어야 하는 거 아닌가요...?
There was a problem hiding this comment.
반영했습니다.
Comment on lines
35
to
40
| private lazy var loginButton = NextStepButton().then{ | ||
| $0.setTitle("로그인", for: .normal) | ||
| $0.isEnabled = false | ||
| $0.backgroundColor = UIColor(rgb: 0x999999) | ||
| $0.addTarget(self, action: #selector(loginButtonTapped), for: .touchUpInside) | ||
| } |
There was a problem hiding this comment.
디자인으론 bold로 되어있는데 NextStepButton이 SemiBold로 되어있어서 티는 잘 안 나지만 bold로 바꾸는 게 좋을 거 같아요!!
There was a problem hiding this comment.
반영했습니다.
Comment on lines
133
to
155
| self.appleLoginButton.snp.makeConstraints{ | ||
| $0.height.width.equalTo(36) | ||
| $0.bottom.equalTo(firstTimeIdeaArchiveLabel.snp.bottom).inset(32) | ||
| $0.bottom.equalTo(self.view.safeAreaLayoutGuide.snp.bottom).inset(96) | ||
| $0.trailing.equalTo(googleLoginButton.snp.leading).offset(-28) | ||
| } | ||
|
|
||
| self.googleLoginButton.snp.makeConstraints{ | ||
| $0.height.width.equalTo(36) | ||
| $0.bottom.equalTo(firstTimeIdeaArchiveLabel.snp.bottom).inset(32) | ||
| $0.bottom.equalTo(self.appleLoginButton.snp.bottom) | ||
| $0.centerX.equalToSuperview().offset(-32) | ||
| } | ||
|
|
||
| self.kakaoLoginButton.snp.makeConstraints{ | ||
| $0.height.width.equalTo(36) | ||
| $0.bottom.equalTo(firstTimeIdeaArchiveLabel.snp.bottom).inset(32) | ||
| $0.bottom.equalTo(self.appleLoginButton.snp.bottom) | ||
| $0.leading.equalTo(view.snp.centerX).offset(14) | ||
| } | ||
|
|
||
| self.githubLoginButton.snp.makeConstraints{ | ||
| $0.height.width.equalTo(36) | ||
| $0.bottom.equalTo(firstTimeIdeaArchiveLabel.snp.bottom).inset(32) | ||
| $0.bottom.equalTo(self.appleLoginButton.snp.bottom) | ||
| $0.leading.equalTo(kakaoLoginButton.snp.trailing).offset(28) | ||
| } |
There was a problem hiding this comment.
이 로그인 버튼들 StackView에 넣어서 관리하는 거 어떤가요? 그러면 코드가 줄어들고 읽기 편할 거 같아요!
There was a problem hiding this comment.
반영했습니다.
There was a problem hiding this comment.
idTextField의 placeholder가 피그마에선 "이메일을 입력해주세요"로 디자인 되어있는데 수정되었나요...?
There was a problem hiding this comment.
반영했습니다.
파라미터의 이름을 param에서 각각의 request로
stackView안에 넣었습니다.
아이디를 입력해주세요 -> 이메일을 입력해주세요
로그인 버튼의 폰트를 semibold에서 bold로
primaryColor를 찾지 못해서 청록색으로 수정했어요.
PrimaryColor로 수정
uuuunseo
reviewed
Aug 12, 2023
| @@ -2,7 +2,7 @@ import UIKit | |||
| import Then | |||
| import SnapKit | |||
|
|
|||
| final class SignupViewController: BaseViewController { | |||
| final class SignupViewController: BaseVC { | |||
There was a problem hiding this comment.
반영했습니다.
SignupViewcontroller -> SignupVC로 변경
uuuunseo
approved these changes
Aug 13, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요 💡
로그인 페이지를 퍼블리싱 했습니다.
작업 내용 💻
수정된 디자인에 맞게 회원가입, 비밀번호 찾기 버튼을 로그인 버튼 위로 퍼블리싱 했습니다.
리뷰해주세요 🙏
inset offset 부분에서 야매로 처리한게 몇개 있어서 리뷰해주시면 감사하겠습니다:)