New function implementation to prevent the remaining balance allocation to protocols with 0% weight

[samster91]

/**
 * Calculate amounts from percentage allocations (100000 => 100%)
 *
 * @param allocations : array of protocol allocations in percentage
 * @param total : total amount
 * @return : array with amounts
 */
function _amountsFromAllocations(uint256[] memory allocations, uint256 total)
  internal view returns (uint256[] memory newAmounts) {
  newAmounts = new uint256[](allocations.length);
  uint256 currBalance;
  uint256 allocatedBalance;
  uint256 firstProtocolIndexWithAllocation;

  for (uint256 i = 0; i < allocations.length; i++) {
    // Take last protocol with valid allocations
    if (allocations[i] > 0){
      firstProtocolIndexWithAllocation = i;
    }
    currBalance = total.mul(allocations[i]).div(FULL_ALLOC);
    allocatedBalance = allocatedBalance.add(currBalance);
    newAmounts[i] = currBalance;
  }

  // Allocate remaining amount to last protocol
  if (total.sub(allocatedBalance) > 0){
    newAmounts[firstProtocolIndexWithAllocation] = newAmounts[firstProtocolIndexWithAllocation].add(total.sub(allocatedBalance));
  }

  return newAmounts;
}