Some minor improvements for Find in page #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't let user feel that we can search content in the library page through findInPage. So we close findInPage when we open the Library, and we close the panel when we open findInPage in the hamburger menu. We shall pay attention to this as well in #881 once this is merged Signed-off-by: Songlin Jiang <[email protected]>
Signed-off-by: Songlin Jiang <[email protected]>
javifernandez
approved these changes
Sep 6, 2023
svillar
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop having findInPage and Panel opened at same time
We shouldn't let user feel that we can search content in the library page through findInPage. So we close findInPage when we open the Library, and we close the panel when we open findInPage in the hamburger menu.
We shall pay attention to this as well in Reorganize Libraries and add search UI in panels #881 once this is merged
Auto focus when findInPage opened; Clear text when hidden
We may want to keep findInPage opened even if the page changes (such as reloading/navigating to new page), to keep consistency with other browsers like Chrome.