Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message UI fix. #578

Closed
Paarmita opened this issue Mar 4, 2020 · 8 comments · Fixed by #598
Closed

Error message UI fix. #578

Paarmita opened this issue Mar 4, 2020 · 8 comments · Fixed by #598
Assignees
Labels
easy Something easy to work on. gssoc20 Girls script summer of code 2020. UI/UX Implement UI/UX

Comments

@Paarmita
Copy link
Member

Paarmita commented Mar 4, 2020

Describe the bug
Text is not aligned correctly when Contributors are not loaded properly and looks something like this.

Screenshot 2020-03-04 at 9 34 30 PM

Expected behavior
It should be aligned properly with proper font size. Try it in your way, or let me know if you need any help with the design.

@Paarmita Paarmita added beginner Something that get you started with project. eg. css change UI/UX Implement UI/UX easy Something easy to work on. gssoc20 Girls script summer of code 2020. labels Mar 4, 2020
@Paarmita Paarmita changed the title Error message UI fix when Contributors not been able to load Error message UI fix when Contributors are not loaded Mar 4, 2020
@divyanshu-rawat divyanshu-rawat changed the title Error message UI fix when Contributors are not loaded Error message UI fix. Mar 4, 2020
@ashishnagpal2498
Copy link
Contributor

I would like to work on this issue.

@shreyakapoor08
Copy link
Contributor

Hey, I want to work on this issue

@divyanshu-rawat
Copy link
Member

@ashishnagpal2498 you are already assigned to #585. So, I am assigning this to @shreyakapoor08.

@Paarmita
Copy link
Member Author

Paarmita commented Mar 9, 2020

@shreyakapoor08 Sorry, I couldn't provide a proper UI for this, but here it is, can you please add this text with defined spacing.

Screenshot 2020-03-10 at 12 07 58 AM

@shreyakapoor08
Copy link
Contributor

@shreyakapoor08 Sorry, I couldn't provide a proper UI for this, but here it is, can you please add this text with defined spacing.

Screenshot 2020-03-10 at 12 07 58 AM

Hey @Paarmita I have made the appropriate changes. Please check. I am attaching the snippet below

Capture

@Paarmita
Copy link
Member Author

@shreyakapoor08 Looks good! Thanks for the changes, it would be great if you can also add a bit more margin on top and bottom of this section similar to what other sections have.

@divyanshu-rawat
Copy link
Member

Please go through #605 before staring this issue, ignore if you have already created a branch out of master.

@shreyakapoor08
Copy link
Contributor

@shreyakapoor08 Looks good! Thanks for the changes, it would be great if you can also add a bit more margin on top and bottom of this section similar to what other sections have.

I have done the corrections. Kindly check

@divyanshu-rawat divyanshu-rawat removed the beginner Something that get you started with project. eg. css change label Mar 11, 2020
divyanshu-rawat added a commit that referenced this issue Mar 11, 2020
Release to Master ☘️.

* Folder restructuring.  Issue: #579, PR: #602 
* Service worker fixes ★. 
* Common LogIn/SignUp UI. ★ Issue: #477, #565. PR: #548.
* Navigator UI Added. Issue: #559, PR: #593 🚀
* UI for Error Boundary. Issue: #578, PR: #598  🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Something easy to work on. gssoc20 Girls script summer of code 2020. UI/UX Implement UI/UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants