Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder structure refactoring. #579

Closed
divyanshu-rawat opened this issue Mar 4, 2020 · 10 comments · Fixed by #602 or #604
Closed

Folder structure refactoring. #579

divyanshu-rawat opened this issue Mar 4, 2020 · 10 comments · Fixed by #602 or #604
Assignees
Labels
enhancement New feature or improvement of existing feature. gssoc20 Girls script summer of code 2020. hard Something complex to work on. RGSoC 2020 Rails girls summer of code 2020

Comments

@divyanshu-rawat
Copy link
Member

Is your feature request related to a problem? Please describe.
In the project we have too many folders and some of them are doing the same job, what I mean is if you look ignitus-Helpers , ignitus-Internals, shared have files in them that are being used all over the application, so why not merge and place everything into one folder lets say ignitus-Helpers that will consist of shared styles, shared components in this was we can get rid of 2 folders namely ignitus-Internals, shared, that will make code structure bit more readable & clean.

Additional context
Let me know by leaving a comment if issue is not clear enough, moreover please keep in mind you have to change lot of imports when you place contents from one folder to another :).
I am available for resolving your queries, ping me if you struck once you took this issue.

@divyanshu-rawat divyanshu-rawat added gssoc20 Girls script summer of code 2020. RGSoC 2020 Rails girls summer of code 2020 hard Something complex to work on. enhancement New feature or improvement of existing feature. labels Mar 4, 2020
@ashishnagpal2498
Copy link
Contributor

I would like to work on this issue.

@debck
Copy link
Member

debck commented Mar 7, 2020

Hey @ashishnagpal2498 , You have still two unmerged PR's. So once they are verified and merged, we will assign you with this one.

@Xtremilicious
Copy link
Member

@divyanshu-rawat @debck Would like to work on this one :)

@divyanshu-rawat
Copy link
Member Author

divyanshu-rawat commented Mar 10, 2020 via email

@Xtremilicious
Copy link
Member

I'm having a problem while committing the code. Help is appreciated.

ScreenShot_20200310200727

ScreenShot_20200310200731

@divyanshu-rawat
Copy link
Member Author

@Xtremilicious try removing CI=true from your package.json and then try committing.

@Xtremilicious
Copy link
Member

Well, now it tells this:
ScreenShot_20200310201430

I searched a bit about this issue, maybe there was a fix that involves cross-env

Let me know if I should try using that package.

@divyanshu-rawat
Copy link
Member Author

divyanshu-rawat commented Mar 10, 2020

@Xtremilicious leave it for now, focus on the current issue, which machine or OS are you using it on? if it is windows then I suppose we need cross-env else it is fine, but we at the moment don't plan to increase the bundle size by adding cross-env. So, as an workaround you just need to bypass it using --no-verify.

@Xtremilicious
Copy link
Member

@divyanshu-rawat I got it to work on my OS(Windows) by changing the syntax a bit; tests were performed successfully. I think this should be added in the contributing docs so that others using Windows OS have no problems committing in the future:)

ScreenShot_20200310204306

@divyanshu-rawat
Copy link
Member Author

divyanshu-rawat commented Mar 10, 2020 via email

@divyanshu-rawat divyanshu-rawat linked a pull request Mar 11, 2020 that will close this issue
divyanshu-rawat added a commit that referenced this issue Mar 11, 2020
Release to Master ☘️.

* Folder restructuring.  Issue: #579, PR: #602 
* Service worker fixes ★. 
* Common LogIn/SignUp UI. ★ Issue: #477, #565. PR: #548.
* Navigator UI Added. Issue: #559, PR: #593 🚀
* UI for Error Boundary. Issue: #578, PR: #598  🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement of existing feature. gssoc20 Girls script summer of code 2020. hard Something complex to work on. RGSoC 2020 Rails girls summer of code 2020
Projects
None yet
4 participants