-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folder structure refactoring. #579
Comments
I would like to work on this issue. |
Hey @ashishnagpal2498 , You have still two unmerged PR's. So once they are verified and merged, we will assign you with this one. |
@divyanshu-rawat @debck Would like to work on this one :) |
Go ahead :)
On Tue 10. Mar 2020 at 14:34, Nilarjun Das ***@***.***> wrote:
@divyanshu-rawat <https://github.com/divyanshu-rawat> @debck
<https://github.com/debck> Would like to work on this one :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#579?email_source=notifications&email_token=ADGXIZX4ZCUZQIFPPSABRQLRGY6VHA5CNFSM4LBXS5D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOLNPWA#issuecomment-597088216>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADGXIZTGFA2UGTXYPFNCRCLRGY6VHANCNFSM4LBXS5DQ>
.
--
Thanks and have a great day!
Best
Divyanshu Rawat
Currently *@Bayrischer Rundfunk* (Govt. of Germany).
Previously Research* @Stanford*,
Product Design @*Harvard* Innovation Labs.
+49 17658817481
*[image: Twitter] <https://htmlsig.com/t/000001DCV8RZ> [image: LinkedIn]
<https://htmlsig.com/t/000001DKT8C6> [image: Github]
<https://htmlsig.com/t/000001DH4GT2> [image: Stack Overflow]
<https://htmlsig.com/t/000001DEFKRT> [image: Behance]
<https://htmlsig.com/t/000001DKZ3AC> *
|
@Xtremilicious try removing |
I searched a bit about this issue, maybe there was a fix that involves cross-env Let me know if I should try using that package. |
@Xtremilicious leave it for now, focus on the current issue, which machine or OS are you using it on? if it is windows then I suppose we need |
@divyanshu-rawat I got it to work on my OS(Windows) by changing the syntax a bit; tests were performed successfully. I think this should be added in the contributing docs so that others using Windows OS have no problems committing in the future:) |
Great 👍 please create an issue and add it there :)
On Tue 10. Mar 2020 at 16:16, Nilarjun Das ***@***.***> wrote:
@divyanshu-rawat <https://github.com/divyanshu-rawat> I got it to work on
my OS(Windows) by changing the syntax a bit; tests were performed
successfully. I think this should be added in the contributing docs so that
others using Windows OS have no problems committing in the future:)
[image: ScreenShot_20200310204306]
<https://user-images.githubusercontent.com/47635607/76327361-ea03d380-630f-11ea-970a-8eaed83174ff.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#579?email_source=notifications&email_token=ADGXIZXKBMLM4XYRIVSKODTRGZKTJA5CNFSM4LBXS5D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOL2W7Q#issuecomment-597142398>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADGXIZUML3EBSSSIIGHBLU3RGZKTJANCNFSM4LBXS5DQ>
.
--
Thanks and have a great day!
Best
Divyanshu Rawat
Currently *@Bayrischer Rundfunk* (Govt. of Germany).
Previously Research* @Stanford*,
Product Design @*Harvard* Innovation Labs.
+49 17658817481
*[image: Twitter] <https://htmlsig.com/t/000001DCV8RZ> [image: LinkedIn]
<https://htmlsig.com/t/000001DKT8C6> [image: Github]
<https://htmlsig.com/t/000001DH4GT2> [image: Stack Overflow]
<https://htmlsig.com/t/000001DEFKRT> [image: Behance]
<https://htmlsig.com/t/000001DKZ3AC> *
|
Is your feature request related to a problem? Please describe.
In the project we have too many folders and some of them are doing the same job, what I mean is if you look
ignitus-Helpers
,ignitus-Internals
,shared
have files in them that are being used all over the application, so why not merge and place everything into one folder lets sayignitus-Helpers
that will consist ofshared styles
,shared components
in this was we can get rid of 2 folders namelyignitus-Internals
,shared
, that will make code structure bit more readable & clean.Additional context
Let me know by leaving a comment if issue is not clear enough, moreover please keep in mind you have to change lot of imports when you place contents from one folder to another :).
I am available for resolving your queries, ping me if you struck once you took this issue.
The text was updated successfully, but these errors were encountered: