Master > Develop #807

divyanshu-rawat · 2020-04-22T16:36:44Z

Utilize ignitus-Shared/index. Utilize ignitus-Shared/index. #806
[dev]: Remove houndCI [dev]: Remove houndCI #811
[ignitus-Shared]: Unit tests [ignitus-Shared]: Unit tests #812
Readme change Readme change #810
Added buttons with icons on left Added buttons with icons on left #809
Secondary Dropdown Secondary Dropdown #808
Unit tests Unit tests #813
[ignitus-Shared/atoms]: unit tests [ignitus-Shared/atoms]: unit tests #814

Rm warn

Develop

...

Utilize ignitus-Shared/index.

codecov · 2020-04-22T16:37:48Z

Codecov Report

Merging #807 into master will increase coverage by 2.27273%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             master       #807         +/-   ##
=================================================
+ Coverage   0.56818%   2.84091%   +2.27273%     
=================================================
  Files             5          5                 
  Lines           176        176                 
  Branches         48         48                 
=================================================
+ Hits              1          5          +4     
+ Misses          175        171          -4

Impacted Files	Coverage Δ
...-ErrorHandlingComponents/errorHandling/validate.js	`19.04762% <0.00000%> (+19.04762%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007dcc6...007dcc6. Read the comment docs.

Develop

…into readme-update

Readme change

> configure eslint for typescript > add prettier plugin in eslint > script to lint files and fix linting errors > add lint script to husky pre-commit & travis build > fix eslint & prettier errors

[dev]: Remove houndCI

hound · 2020-04-25T20:30:47Z

src/ignitus-HomePage/ignitus-Testimonial/selectors.test.js

@@ -23,7 +23,7 @@ describe('Testimonial Selectors', () => {
        author: 'John Smith',
        source: 'https://example.com',
      }];
-      const testimonialState = data
+      const testimonialState = data;


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2020-04-25T20:30:48Z

src/ignitus-Api/index.js

@@ -41,7 +41,7 @@ async function getHeaders(name) {
      headers: {
        'If-None-Match': item.etag,
      },
-      validateStatus: status => (status >= 200 && status < 300) || status === 304,
+      validateStatus: (status) => (status >= 200 && status < 300) || status === 304,


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-04-25T20:30:48Z

src/ignitus-Api/index.js

@@ -21,7 +21,7 @@ export async function getTestimonialData() {
    }
    return await DBHelper.getDataFromDB(t.TESTIMONIALS_STORE);
  } catch (err) {
-    return new Promise(reject => reject(err));
+    return new Promise((reject) => reject(err));


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-04-25T20:30:48Z

src/registerServiceWorker.js

+        }).catch((err) => {
+          console.log('failure', err);
+        });
+      } catch (error) {


Expected an assignment or function call and instead saw an expression.
Expected an identifier and instead saw ')'.
Expected an identifier and instead saw 'catch'.
Expected an operator and instead saw '('.
Missing semicolon.

hound · 2020-04-25T20:30:48Z

src/registerServiceWorker.js

-      catch (error) {
+        }).then((response) => {
+          console.log('success', response);
+        }).catch((err) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-04-25T20:30:48Z

src/registerServiceWorker.js

-        })
-      } 
-      catch (error) {
+        }).then((response) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-04-25T20:30:49Z

src/registerServiceWorker.js

@@ -47,20 +47,19 @@ function registerValidSW(swUrl) {
          'BMRATagxJMbZdcX-a-lwaMC93vL7-Kmr3trsTc_g0HJy6C6UGCRMSKfxzJUOjAsXt3W5Ov7t_a8J9y9qROw9mFE',
        ),
      });
-        try {
+      try {


Expected ')' and instead saw 'try'.
Missing semicolon.

hound · 2020-04-25T20:30:49Z

src/ignitus-Shared/ignitus-ErrorHandlingComponents/errorHandling/validate.js

@@ -17,7 +17,7 @@ const minLengthValidator = (value, minLength) => value.length >= minLength;
 * @param  value
 * @return
 */
-const requiredValidator = value => value.trim() !== '';
+const requiredValidator = (value) => value.trim() !== '';


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2020-04-25T20:30:49Z

src/ignitus-HomePage/ignitus-Testimonial/selectors.test.js

@@ -23,7 +23,7 @@ describe('Testimonial Selectors', () => {
        author: 'John Smith',
        source: 'https://example.com',
      }];
-      const testimonialState = data
+      const testimonialState = data;


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2020-04-25T20:30:49Z

src/ignitus-Api/index.js

@@ -41,7 +41,7 @@ async function getHeaders(name) {
      headers: {
        'If-None-Match': item.etag,
      },
-      validateStatus: status => (status >= 200 && status < 300) || status === 304,
+      validateStatus: (status) => (status >= 200 && status < 300) || status === 304,


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-04-25T20:30:49Z

src/ignitus-Api/index.js

@@ -21,7 +21,7 @@ export async function getTestimonialData() {
    }
    return await DBHelper.getDataFromDB(t.TESTIMONIALS_STORE);
  } catch (err) {
-    return new Promise(reject => reject(err));
+    return new Promise((reject) => reject(err));


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

enzyme-to-json is useful to generate html snapshot of component jest-emotion is used to test emotion styled component

[ignitus-Shared]: Unit tests

Added buttons with icons on left

Secondary Dropdown

Unit tests

[ignitus-Shared/atoms]: unit tests

Dishebh and others added 7 commits April 11, 2020 02:07

Merge pull request #2 from Dishebh/rm-warn

e660f61

Rm warn

Merge pull request #3 from Ignitus/develop

b087444

Develop

Merge branch 'develop' of github.com:Dishebh/Ignitus-client into develop

351cfc1

Merge pull request #2 from Ignitus/develop

59200e1

Develop

Merge pull request #3 from Ignitus/develop

6e26233

...

Utilize ignitus-Shared/index as much as possible

e73ded2

Merge pull request #806 from Marvin9/minify/import-path

3d81224

Utilize ignitus-Shared/index.

pr-triage bot added the PR: unreviewed label Apr 22, 2020

divyanshu-rawat temporarily deployed to ignitus-pipe-develop-tdk5hc9iy April 22, 2020 16:37 Inactive

auto-assign bot requested review from gittysachin, Marvin9 and Paarmita April 22, 2020 16:38

meghanacosmos and others added 17 commits April 23, 2020 02:15

search bar without filtering functionality

a6c3771

added filter functionality

5e852ea

minor fixes

606ed0d

Merge branch 'develop' into DropDownSec

3a18afd

removed unused import

f740ff5

Update secondaryDropDown.jsx

88d1f5d

Update secondaryDropDown.jsx

4d7494a

Update secondaryDropDown.jsx

228b6f4

Merge pull request #4 from Ignitus/develop

b55321e

Develop

fixes

c1a272f

feature: added buttons with icons on left

9b3ec40

Merge branch 'develop' of https://github.com/AgaPer100/Ignitus-client …

08c1307

…into readme-update

changed punctuation mark in README file

ae5e76c

Merge pull request #810 from AgaPer100/readme-change

b5b77b6

Readme change

adding flex property to buttons with icons

7d52872

Remove houndCI

edda696

> configure eslint for typescript > add prettier plugin in eslint > script to lint files and fix linting errors > add lint script to husky pre-commit & travis build > fix eslint & prettier errors

Fix deepscan issue

1b9cffa

Merge pull request #811 from Marvin9/eslint-typescript

1d1faf4

[dev]: Remove houndCI

hound bot reviewed Apr 25, 2020

View reviewed changes

Dishebh and others added 20 commits April 27, 2020 21:37

fix lint issue

a825454

lint fix

8d3302f

Merge branch 'develop' into buttons

ac17ee2

Add enzyme-to-json & jest-emotion as dev dependencies

d1f6b1a

enzyme-to-json is useful to generate html snapshot of component jest-emotion is used to test emotion styled component

Add tests to few shared components

737ef97

Merge pull request #812 from Marvin9/unit-tests

3261793

[ignitus-Shared]: Unit tests

Merge branch 'develop' into buttons

1f95ddf

refactoring 🎯

9b7954c

Merge pull request #809 from Dishebh/buttons

fbb26fe

Added buttons with icons on left

Add tests for few components

1b62093

Minor modification in components

210d81c

Update component change

e8bd670

Merge branch 'develop' into DropDownSec

f9f173d

Refactoring 🔨

6d8eb47

Refactoring 🎯

f58b094

Merge pull request #808 from Meghana-12/DropDownSec

4577a28

Secondary Dropdown

Revert functionality of defaultPasswordInput & update tests

f20ca70

Merge pull request #813 from Marvin9/unit-tests

9986392

Unit tests

Added unit tests

37f4317

Merge pull request #814 from Marvin9/unit-tests

007dcc6

[ignitus-Shared/atoms]: unit tests

Ignitus-bot merged commit ffde53a into master May 2, 2020

pr-triage bot added PR: merged and removed PR: unreviewed labels May 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Master > Develop #807

Master > Develop #807

divyanshu-rawat commented Apr 22, 2020 •

edited

Loading

codecov bot commented Apr 22, 2020 •

edited

Loading

hound bot Apr 25, 2020

hound bot Apr 25, 2020

hound bot Apr 25, 2020

hound bot Apr 25, 2020

hound bot Apr 25, 2020

hound bot Apr 25, 2020

hound bot Apr 25, 2020

hound bot Apr 25, 2020

hound bot Apr 25, 2020

hound bot Apr 25, 2020

hound bot Apr 25, 2020

Master > Develop #807

Master > Develop #807

Conversation

divyanshu-rawat commented Apr 22, 2020 • edited Loading

codecov bot commented Apr 22, 2020 • edited Loading

Codecov Report

hound bot Apr 25, 2020

Choose a reason for hiding this comment

hound bot Apr 25, 2020

Choose a reason for hiding this comment

hound bot Apr 25, 2020

Choose a reason for hiding this comment

hound bot Apr 25, 2020

Choose a reason for hiding this comment

hound bot Apr 25, 2020

Choose a reason for hiding this comment

hound bot Apr 25, 2020

Choose a reason for hiding this comment

hound bot Apr 25, 2020

Choose a reason for hiding this comment

hound bot Apr 25, 2020

Choose a reason for hiding this comment

hound bot Apr 25, 2020

Choose a reason for hiding this comment

hound bot Apr 25, 2020

Choose a reason for hiding this comment

hound bot Apr 25, 2020

Choose a reason for hiding this comment

divyanshu-rawat commented Apr 22, 2020 •

edited

Loading

codecov bot commented Apr 22, 2020 •

edited

Loading