New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secondary Dropdown #808

Merged

divyanshu-rawat merged 14 commits into Ignitus:develop from meghanacosmos:DropDownSec

Apr 29, 2020

Contributor

meghanacosmos commented Apr 22, 2020 •

edited

Loading

related to issue #560
Component can be viewed at /interface/secondaryDropdown
To test this PR, start searching with H in the input to view the dropdown.
As of now, these are the entries:
Harpar Hopman
Hara Hopman
Harbour Center
Harvard University
Henry Harbour
Hara Jackson

meghanacosmos and others added 5 commits

April 16, 2020 00:45


          Merge pull request #2 from Ignitus/develop

59200e1

Develop


          Merge pull request #3 from Ignitus/develop

6e26233

...


          search bar without filtering functionality

a6c3771


          added filter functionality

5e852ea


          minor fixes

606ed0d

pr-triage bot added the PR: unreviewed label

hound bot reviewed

View reviewed changes

src/ignitus-UserInterfaceBook/Components/Atoms/interfaceSecondaryDropdown/Components/index.tsx Outdated

		import * as S from '../styles'


		export const interfaceSecondaryDropDown: React.FC = () => (

hound bot Apr 22, 2020

Parsing error: Unexpected token :

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/types.ts Outdated

		@@ -0,0 +1,9 @@
		export type SecondaryDropDownProps = {

hound bot Apr 22, 2020

Parsing error: Unexpected token type

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                    "name": "Hara Jackson"
+                  }
+                ]

hound bot Apr 22, 2020

Expected indentation of 0 spaces but found 2 indent
Missing semicolon semi

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Hara Jackson"
+                  }

hound bot Apr 22, 2020

Expected indentation of 2 spaces but found 4 indent
Missing trailing comma comma-dangle

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                  },
+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Hara Jackson"

hound bot Apr 22, 2020

Expected indentation of 4 spaces but found 6 indent
Missing trailing comma comma-dangle
Strings must use singlequote quotes
Unnecessarily quoted property 'name' found quote-props

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Harvard University"
+                  },

hound bot Apr 22, 2020

Expected indentation of 2 spaces but found 4 indent

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                  },
+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Harvard University"

hound bot Apr 22, 2020

Expected indentation of 4 spaces but found 6 indent
Missing trailing comma comma-dangle
Strings must use singlequote quotes
Unnecessarily quoted property 'name' found quote-props

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                    "name": "Harbour Center"
+                  },
+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",

hound bot Apr 22, 2020

Expected indentation of 4 spaces but found 6 indent
Strings must use singlequote quotes
Unnecessarily quoted property 'avatarLink' found quote-props

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Harbour Center"
+                  },
+                  {

hound bot Apr 22, 2020

Expected indentation of 2 spaces but found 4 indent

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Harbour Center"
+                  },

hound bot Apr 22, 2020

Expected indentation of 2 spaces but found 4 indent


          Merge branch 'develop' into DropDownSec

3a18afd

hound bot reviewed

View reviewed changes

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                  },
+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Harbour Center"

hound bot Apr 22, 2020

Expected indentation of 4 spaces but found 6 indent
Missing trailing comma comma-dangle
Strings must use singlequote quotes
Unnecessarily quoted property 'name' found quote-props

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                    "name": "Hara Hopman"
+                  },
+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",

hound bot Apr 22, 2020

Expected indentation of 4 spaces but found 6 indent
Strings must use singlequote quotes
Unnecessarily quoted property 'avatarLink' found quote-props

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Hara Hopman"
+                  },
+                  {

hound bot Apr 22, 2020

Expected indentation of 2 spaces but found 4 indent

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Hara Hopman"
+                  },

hound bot Apr 22, 2020

Expected indentation of 2 spaces but found 4 indent

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                  },
+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Hara Hopman"

hound bot Apr 22, 2020

Expected indentation of 4 spaces but found 6 indent
Missing trailing comma comma-dangle
Strings must use singlequote quotes
Unnecessarily quoted property 'name' found quote-props

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Harpar Hopman"
+                  },
+                  {

hound bot Apr 22, 2020

Expected indentation of 2 spaces but found 4 indent

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Harpar Hopman"
+                  },

hound bot Apr 22, 2020

Expected indentation of 2 spaces but found 4 indent

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+              export const Details = [
+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",
+                    "name": "Harpar Hopman"

hound bot Apr 22, 2020

Expected indentation of 4 spaces but found 6 indent
Missing trailing comma comma-dangle
Strings must use singlequote quotes
Unnecessarily quoted property 'name' found quote-props

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

+              export const Details = [
+                  {
+                    "avatarLink": "https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png",

hound bot Apr 22, 2020

Expected indentation of 4 spaces but found 6 indent
Strings must use singlequote quotes
Unnecessarily quoted property 'avatarLink' found quote-props

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/constants.ts Outdated

		@@ -0,0 +1,29 @@

		export const Details = [
		{

hound bot Apr 22, 2020

Expected indentation of 2 spaces but found 4 indent

auto-assign bot requested review from divyanshu-rawat, gittysachin, Marvin9 and Paarmita

April 22, 2020 22:52

codecov bot commented Apr 22, 2020 •

edited

Loading

Codecov Report

Merging #808 into develop will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##            develop       #808   +/-   ##
===========================================
  Coverage   2.84091%   2.84091%           
===========================================
  Files             5          5           
  Lines           176        176           
  Branches         48         48           
===========================================
  Hits              5          5           
  Misses          171        171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d81224...c1a272f. Read the comment docs.

meghanacosmos added 4 commits

April 23, 2020 04:33


          removed unused import

f740ff5


          Update secondaryDropDown.jsx

88d1f5d


          Update secondaryDropDown.jsx

4d7494a


          Update secondaryDropDown.jsx

228b6f4

Marvin9 reviewed

View reviewed changes

...gnitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/Components/secondaryDropDown.jsx Outdated

		import { Details } from '../constants';


		export default function SecondaryDropDown() {

Member

Marvin9 Apr 23, 2020

To be consistent to code structure

Suggested change

      
            export default function SecondaryDropDown() {
          
            export const SecondaryDropDown: React.FC = () => {

Change accordingly in Components/index.ts

Also make an entry in ignitus-Shared/index.ts, for easy access.

Contributor Author

meghanacosmos Apr 23, 2020 •

edited

Loading

Sure!Thank you.


          fixes

c1a272f

hound bot reviewed

View reviewed changes

src/ignitus-Shared/index.ts Outdated

		@@ -32,6 +32,7 @@ export {DefaultMultiMediaInput} from './ignitus-DesignSystem/ignitus-Atoms/ignit

		export {DefaultSearchInput} from './ignitus-DesignSystem/ignitus-Atoms/ignitus-defaultSearchInput/Components';

		export {SecondaryDropDown} from './ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/Components/secondaryDropDown';

hound bot Apr 23, 2020

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

...gnitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/Components/secondaryDropDown.tsx Outdated

		import {Details} from '../constants';


		export const SecondaryDropDown: React.FC = () => {

hound bot Apr 23, 2020

Parsing error: Unexpected token :

Paarmita reviewed

View reviewed changes

src/ignitus-Routes/ignitus-UserInterfaceBookRoutes/index.tsx

                         path="/interface/defaultDropdown"
                         component={interfaceDropDown}
                       />
+                      <Route
+                        path="/interface/secondaryDropdown"

Member

Paarmita Apr 23, 2020

I cannot see your dropdown on this route, so can you please add it. Also, try to add the information on how can we view your new PR, like mentioning the route in this case.

divyanshu-rawat added 3 commits

April 29, 2020 23:28


          Merge branch 'develop' into DropDownSec

f9f173d


          Refactoring 🔨

6d8eb47


          Refactoring 🎯

f58b094

divyanshu-rawat approved these changes

View reviewed changes

Member

divyanshu-rawat left a comment

Left some feedback, though I resolved it myself but still left will be helpful foe you to enhance your skills. Overall great work 🎯 I told you , you can do ti! 🏆

...gnitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/Components/secondaryDropDown.tsx Outdated

+                    setShowOptions(true);
+                };
+                React.useEffect(() => {
+                   const results = [] = Details.filter(person =>

Member

divyanshu-rawat Apr 29, 2020

Did you checked the functionality of dropdown is affected after you added adding [] = , nothing is shown in dropdown the problem is that [] = Details.filter() is equivalent to [] || Details.filter() , so it implies either assign one of the value to array and every-time it assigns it [], so dropdown was always empty, but I fixed it by removing [] =

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/styles.ts Outdated

+                padding-left:0.25rem;
+                color: ${C.IgnitusBlue};
+                font-weight: ${F.SemiBold};
+                :: placeholder{

Member

divyanshu-rawat Apr 29, 2020

use


 &::placeholder {
    color: ${C.IgnitusBlue};
    font-weight: ${F.SemiBold};
  }

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/styles.ts

+              export const Avatar = styled.img`
+                border-radius: 50%;
+                width : 2.5rem;
+                margin: 0 1rem 0 1rem;

Member

divyanshu-rawat Apr 29, 2020

use 0 1rem;

...gnitus-DesignSystem/ignitus-Atoms/ignitus-secondaryDropDown/Components/secondaryDropDown.tsx Outdated

@@ @@ -38,13 +36,13 @@ export default function SecondaryDropDown() { @@
                       {showOptions &&
                       <S.OptionsContainer>
                         {searchResults.map((person, index) =>

Member

divyanshu-rawat Apr 29, 2020

use de -structure operator to extract { name, avatarLink } in map.

          {searchResults.map(({ name, avatarLink }, index) => (
            <S.CardWrapper key={`${name}`}>
              <S.Avatar src={avatar} />
              <S.NameWrapper>
                <H.Heading5>{name}</H.Heading5>
              </S.NameWrapper>
            </S.CardWrapper>
          ))}

pr-triage bot added PR: partially-approved PR: unreviewed and removed PR: unreviewed PR: partially-approved labels

divyanshu-rawat merged commit 4577a28 into Ignitus:develop

pr-triage bot added PR: merged and removed PR: unreviewed labels

divyanshu-rawat mentioned this pull request

Master > Develop #807

Merged

Contributor Author

meghanacosmos commented Apr 30, 2020

Left some feedback, though I resolved it myself but still left will be helpful foe you to enhance your skills. Overall great work 🎯 I told you , you can do ti! 🏆

Sure, I'll go through the reviews. Thank you so much

meghanacosmos deleted the DropDownSec branch

April 30, 2020 19:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hound[bot] hound[bot] left review comments

Paarmita Paarmita left review comments

Marvin9 Marvin9 left review comments

divyanshu-rawat divyanshu-rawat approved these changes

gittysachin Awaiting requested review from gittysachin

Labels