Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError in _build_bot function with pydicom.filebase.DicomBytesIO #313

Closed
denesd opened this issue Oct 21, 2024 · 4 comments
Closed

TypeError in _build_bot function with pydicom.filebase.DicomBytesIO #313

denesd opened this issue Oct 21, 2024 · 4 comments

Comments

@denesd
Copy link

denesd commented Oct 21, 2024

In pydicom 3.0.1 DicomBytesIO's and DicomFileLike read function changed an only accepts one argument. The current implementation https://github.com/ImagingDataCommons/highdicom/blob/master/src/highdicom/io.py#L188 seems to be compatible with the 2.4.4 based DicomIO.

The following error is raised:

first_two_bytes = fp.read(2, True)
E           TypeError: read expected at most 1 argument, got 2
@CPBridge
Copy link
Collaborator

Thanks for reporting this issue @denesd, hopefully this should be a simple fix. I'll take a look in the next few days

@CPBridge
Copy link
Collaborator

Hi @denesd, could you please test whether #314 fixes your issue?

@denesd
Copy link
Author

denesd commented Oct 24, 2024

Hi @CPBridge , I've tested the fix and it seems to be working as expected 💯

@CPBridge
Copy link
Collaborator

Closed by #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants