Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

border shouldn't affect edit's area #702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

border shouldn't affect edit's area #702

wants to merge 1 commit into from

Conversation

ryuukk
Copy link
Contributor

@ryuukk ryuukk commented Sep 24, 2024 •
edited
Loading

Before/After:

image

@ryuukk
Copy link
Contributor Author

ryuukk commented Sep 24, 2024 •
edited
Loading

Unless my assumption about "border" is wrong, is it supposed to be outer or inner? seems like it does both, so perhaps only "half" could shrink the area?

@RobLoach
Copy link
Contributor

Looks like this was from #592 . Anywhere else we need to update here? Thanks for investigating.

@RobLoach
Copy link
Contributor

RobLoach commented Sep 30, 2024 •
edited
Loading

I had a test on this, and it seems to work for me. Anything else we should consider before merging?

As for which value is for which, I'd love for us to move to a similar to the css...

Screenshot from 2024-09-30 13-01-50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryuukk @RobLoach