fix/ofac_list_url'

[aarmoa]

• Fixed link to official ofac.json file
• Refreshed the local copy of the file after the update

Summary by CodeRabbit

• New Features
  • Updated the source URL for the OFAC list to improve data retrieval.
  • Added 66 new Ethereum addresses to the compliance list.
  • Removed 7 outdated addresses from the compliance list.
  • Updated one existing address for accuracy.

These changes enhance the application's compliance capabilities and ensure users have access to the most current data.

[coderabbitai]

Walkthrough

The pull request includes updates to the DefaultOfacListURL constant in the client/chain/ofac.go file, changing the source URL for the OFAC list. Additionally, the injective_data/ofac.json file has been modified to add 66 new Ethereum addresses and remove 7 existing addresses, including one address that was replaced with another. These changes primarily affect the data source and content of the OFAC list without altering the existing logic or functionality of the application.

Changes

File	Change Summary
client/chain/ofac.go	Updated DefaultOfacListURL from a specific JSON file URL to a new path including refs/heads/master/json.
injective_data/ofac.json	Added 66 new Ethereum addresses, removed 7 existing addresses, and replaced one address.

Possibly related PRs

• (feat) Add OFAC list check #236: Introduces an OfacChecker to the chainClient, related to the OFAC list functionality.
• Release/v1.52.0 #242: Integrates an OfacChecker into the chainClient, enhancing compliance checks against the OFAC list.
• (fix/solve) Solve ofac.json path issue #244: Modifies the getOfacListPath function in client/chain/ofac.go, related to the OFAC list retrieval.
• Fix/sync dev after v1.52.1 #245: Addresses path determination for the OFAC list in client/chain/ofac.go, connecting to the URL changes.
• Fix/make OFAC list file path relative #251: Modifies the ofac.go file regarding the path of the OFAC list, tying back to the URL updates.
• Fix/sync dev after v1 53 0 #252: Updates the ofac.go file to enhance the structure and visibility of constants related to the OFAC list.

Suggested reviewers

• PavelInjective

🐰 In the meadow, I hop with glee,
New addresses added, as fresh as can be!
The OFAC list now shines so bright,
With paths updated, all feels right.
Hopping through code, a joyful sight! 🌼✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint

level=warning msg="[lintersdb] The name "gas" is deprecated. The linter has been renamed to: gosec."
level=warning msg="[lintersdb] The linter named "megacheck" is deprecated. It has been split into: gosimple, staticcheck, unused."

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)

injective_data/ofac.json (1)

1-157: Consider adding documentation about OFAC compliance

This is a critical compliance file. Consider adding documentation about:

• The source and update frequency of this list
• The process for updating this list
• The implications of these addresses being blocked

Would you like me to help create a documentation template or open a GitHub issue to track this task?

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4ae8d48 and 89605e1.

📒 Files selected for processing (2)

• client/chain/ofac.go (1 hunks)
• injective_data/ofac.json (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• client/chain/ofac.go

[coderabbitai]

💡 Codebase verification

Incorrect replacement of OFAC address and list is unsorted

• The old address 0x19aa5fe80d33a56d56c78e82ea5e50e5d80b4dff was not removed.
• The list of addresses is not sorted, which may lead to maintenance challenges.

🔗 Analysis chain

Verify data integrity and compliance implications

This file contains critical OFAC compliance data. Let's verify its integrity:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the integrity of the OFAC list

# Check for valid Ethereum address format
echo "Checking for invalid Ethereum addresses..."
cat injective_data/ofac.json | jq -r '.[]' | grep -v '^0x[a-fA-F0-9]\{40\}$' || echo "All addresses are valid"

# Check for duplicates
echo -e "\nChecking for duplicates..."
cat injective_data/ofac.json | jq -r '.[]' | sort | uniq -d || echo "No duplicates found"

# Check if addresses are sorted
echo -e "\nChecking if addresses are sorted..."
cat injective_data/ofac.json | jq -r '.[]' > addresses.txt
if diff <(cat addresses.txt) <(sort addresses.txt); then
    echo "Addresses are properly sorted"
else
    echo "Addresses are not sorted"
fi
rm addresses.txt

# Verify the specific changes mentioned in the summary
echo -e "\nVerifying specific changes..."
echo "Checking if 0x19aa5fe80d33a56d56c78e82ea5e50e5d80b4dff was replaced..."
cat injective_data/ofac.json | jq -r '.[]' | grep -q "0x19aa5fe80d33a56d56c78e82ea5e50e5d80b4dff" && echo "Old address still present" || echo "Old address removed"
cat injective_data/ofac.json | jq -r '.[]' | grep -q "0x19f8f2b0915daa12a3f5c9cf01df9e24d53794f7" && echo "New address added" || echo "New address missing"

Length of output: 8428

---

💡 Codebase verification

OFAC List Integration Requires Attention

• Hardcoded OFAC addresses found in multiple files.
• Addresses in injective_data/ofac.json are not sorted.
• Old address 0x19aa5fe80d33a56d56c78e82ea5e50e5d80b4dff is still present.
• New address 0x19f8f2b0915daa12a3f5c9cf01df9e24d53794f7 has been added.
• Shell script encountered errors during execution.

🔗 Analysis chain

Verify integration with the OFAC list URL update

Since the PR objectives mention updating the OFAC list URL, let's verify the integration:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the OFAC list URL update integration

# Check if the URL is referenced in the codebase
echo "Checking for OFAC URL references..."
rg -l "DefaultOfacListURL" --type go

# Check if there are any hardcoded OFAC addresses in the codebase
echo -e "\nChecking for hardcoded addresses..."
rg -l "0x[a-fA-F0-9]{40}" --type go

Length of output: 8595