Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sync dev with v1.54.1 #267

Merged
merged 3 commits into from
Dec 9, 2024
+5 −50
Merged

Feat/sync dev with v1.54.1 #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bc78b7
fix: update OFAC list URL and filename
PavelInjective Dec 3, 2024
67353b0
(fix) remove ofac.json from client dir
PavelInjective Dec 4, 2024
48e6836
Merge pull request #266 from InjectiveLabs/fix/update-ofac-name
PavelInjective Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 0 additions & 48 deletions client/chain/injective_data/ofac.json
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion client/chain/ofac.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
)

const (
DefaultOfacListURL = "https://raw.githubusercontent.com/InjectiveLabs/injective-lists/refs/heads/master/json/wallets/ofac.json"
DefaultOfacListURL = "https://raw.githubusercontent.com/InjectiveLabs/injective-lists/refs/heads/master/json/wallets/ofacAndRestricted.json"
)

var (
Expand Down
5 changes: 4 additions & 1 deletion injective_data/ofac.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,5 +154,8 @@
"0xfac583c0cf07ea434052c49115a4682172ab6b4f",
"0xfd8610d20aa15b7b2e3be39b396a1bc3516c7144",
"0xfec8a60023265364d066a1212fde3930f6ae8da7",
"0xffbac21a641dcfe4552920138d90f3638b3c9fba"
"0xffbac21a641dcfe4552920138d90f3638b3c9fba",
"0xc5801cd781d168e2d3899ad9c39d8a2541871298",
"0x0992E2D17e0082Df8a31Bf36Bd8Cc662551de68B",
"0x8aa07899eb940f40e514b8efdb3b6af5d1cf7bb"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix: Invalid Ethereum address length

The address 0x8aa07899eb940f40e514b8efdb3b6af5d1cf7bb is missing one character to be a valid Ethereum address (39 characters instead of 40 after '0x').

Please verify and correct the address. A valid Ethereum address should be 42 characters long (including '0x' prefix).

Comment on lines +158 to +160
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Invalid Ethereum address format detected

The address 0x8aa07899eb940f40e514b8efdb3b6af5d1cf7bb is invalid as it contains only 38 hexadecimal characters after the '0x' prefix instead of the required 40 characters. No duplicates were found in the file.

  • 0x8aa07899eb940f40e514b8efdb3b6af5d1cf7bb needs to be corrected to a valid 40-character Ethereum address
🔗 Analysis chain

Verify format of new Ethereum addresses

The newly added addresses need verification for correct Ethereum address format and checksums.

Let's verify the address format and check for duplicates:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify Ethereum address format and check for duplicates

# Check if addresses follow the Ethereum address format (0x followed by 40 hex characters)
for addr in "0xc5801cd781d168e2d3899ad9c39d8a2541871298" "0x0992E2D17e0082Df8a31Bf36Bd8Cc662551de68B" "0x8aa07899eb940f40e514b8efdb3b6af5d1cf7bb"; do
    if ! echo "$addr" | grep -qE "^0x[0-9a-fA-F]{40}$"; then
        echo "Invalid address format: $addr"
    fi
done

# Check for duplicates in the entire file
jq -r 'group_by(.) | map(select(length > 1)) | .[]' injective_data/ofac.json

Length of output: 911

]
Loading