Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on Performance Benefits of onKoinStartup vs. startKoin #2002

Open
AhmedAbidii opened this issue Sep 25, 2024 · 2 comments
Open
Labels
question Usage question

Comments

@AhmedAbidii
Copy link

Hello,

In the AndroidX Startup: Optimized Loading blog post, it's mentioned that using onKoinStartup:

"reduces load times by up to 40%, improving performance for applications using Koin."

However, in the Koin Android documentation, it states that switching from onKoinStartup to the regular startKoin:

"can result in over 30% of startup time gained."

This seems contradictory. Since onKoinStartup was introduced in Koin 4.0 to optimize startup performance, shouldn't it provide better performance than the regular startKoin? Could you please clarify the expected behavior?

Thank you!

@blazmag
Copy link

blazmag commented Oct 23, 2024

The direct quote is:

"Gain over from onKoinStartup to regular startKoin can go over 30% of time gained, for startup time."

My 5 cents, some parts of the documentation would greatly benefit from a rewrite by a native english speaker. I think its just badly phrased and I read this as "if you use onKoinStartup you gain 30% lower start times vs startKoin" but I hope one of the devs can confirm.

@arnaudgiuliani
Copy link
Member

You are all welcome to help with documentation :) Gain part is rewritten, and should be more part of some benchmark article.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Usage question
Projects
None yet
Development

No branches or pull requests

3 participants