Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope has no source by default #2059

Open
StenSoft opened this issue Nov 20, 2024 · 0 comments
Open

Scope has no source by default #2059

StenSoft opened this issue Nov 20, 2024 · 0 comments

Comments

@StenSoft
Copy link

When creating a scope with T.newScope(), the scope has no source by default because T.createScope()'s source defaults to null instead of this.

https://github.com/InsertKoinIO/koin/blob/main/projects/android/koin-android/src/main/java/org/koin/android/scope/ComponentCallbacksExt.kt#L25

If this is intentional then:

  1. This needs to be documented
  2. newScope needs to be able to pass source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant