Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: modify wrapping to produce float mesh coordinate type #79

Closed
wants to merge 2 commits into from
Closed

ENH: modify wrapping to produce float mesh coordinate type #79

wants to merge 2 commits into from

Commits on Nov 27, 2024

  1. ENH: modify wrapping to produce float mesh coordinate type 

    When used with unsigned char input images, which is the common case,
the produced mesh would use UC as coordinate type.
This would not only cause a massive loss in precision and range,
but is not wrapped with itk::Mesh class thus causing runtime error:

   itk.meshwrite(mesh, file_path)
     ...
itk.support.extras.TemplateTypeError: itk.MeshFileWriter is not wrapped for input type `itk.Mesh[itk.UC,3]`.
To limit the size of the package, only a limited number of
types are available in ITK Python.
...
Supported input types:
itk.Mesh[itk.F,2]
itk.Mesh[itk.D,2]
itk.Mesh[itk.F,3]
itk.Mesh[itk.D,3]
    @dzenanz
    dzenanz committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    33ac4f0 View commit details
    Browse the repository at this point in the history

  2. ENH: Update CI

    @dzenanz
    dzenanz committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    fa9d67e View commit details
    Browse the repository at this point in the history