Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rate Limit To Request Actions #188

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Add Rate Limit To Request Actions #188

merged 2 commits into from
Oct 12, 2023

Conversation

mrsrec
Copy link
Contributor

@mrsrec mrsrec commented Oct 2, 2023 •
edited
Loading

Implements Rate-limiting To Request Actions.

Required Config For LocalSettings.php:

$wgRateLimits["requestaccountaction"]["ip"] = [1, 60];

Closes #144

@mrsrec mrsrec changed the title Update RequestPage.php Add rate limit to request actions Oct 2, 2023
@mrsrec mrsrec changed the title Add rate limit to request actions Add Rate Limit To Request Actions Oct 2, 2023
@jacob-g
Copy link
Member

jacob-g commented Oct 2, 2023

At first glance looks good, I'll test on my local when I get the chance.

@jacob-g jacob-g self-requested a review October 2, 2023 17:34
jacob-g
jacob-g approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@jacob-g jacob-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my local. Merging.

@jacob-g jacob-g merged commit 77a7cb5 into InternationalScratchWiki:master Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-g jacob-g jacob-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 60-second rule for request comments
2 participants
@mrsrec @jacob-g