Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description field in SCRIPT based registration certificate says "DRep Key Registration Certificate" #756

Open
CarlosLopezDeLara opened this issue May 12, 2024 · 6 comments

Comments

@CarlosLopezDeLara
Copy link
Contributor

Description

When generating a script based DRep registration certificate, the "Description" field in the text envelope still shows "DRep Key Registration Certificate".

cardano-cli conway governance drep registration-certificate \
  --drep-script-hash drep-multisig.hash \
  --key-reg-deposit-amt "$drepDeposit" \
  --out-file drep-multisig-reg.cert

cat drep-multisig-reg.cert
{
    "type": "CertificateConway",
    "description": "DRep Key Registration Certificate",
    "cborHex": "84108201581c1d8fe9486b5fb282287568f04445c8f4d6cddf76ce2df527fd7debbe1a001e8480f6"
}

Provide a brief summary of the issue. If possible, include the expected result and the observed result.

Steps to Reproduce

  1. Create a multisignature Native script
  2. Get its hash
  3. Generate a DRep registration certificate using --drep-script-hash option.
  4. Verify that the certificate's description says DRep Key Registration Certificate.
    ...

Additional Context

Possible Solution

We can generalize the description to say "DRep Registration Certificate" or include some logic to differentiate between key and script.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Jun 12, 2024
@smelc smelc self-assigned this Jun 12, 2024
@smelc smelc removed the Stale label Jun 12, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Jul 13, 2024
@smelc smelc removed the Stale label Jul 15, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Aug 15, 2024
@smelc smelc removed the Stale label Aug 19, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Sep 19, 2024
@smelc smelc removed the Stale label Sep 19, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Oct 20, 2024
@smelc smelc removed the Stale label Oct 28, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Nov 28, 2024
@smelc smelc removed the Stale label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants