cardano-testnet: use new output of "transaction submit" #6003
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Jimbo4350
requested changes
Oct 4, 2024
| then do | ||
| H.note_ "Expected output of \"transaction submit\" not to be empty" | ||
| H.failure | ||
| else pure $ last $ lines stdout |
There was a problem hiding this comment.
This is a poor way of obtaining the txid. The txid can be calculated from the tx itself and you should query the mempool to confirm indeed if it was submitted or not.
smelc
force-pushed
the
smelc/test-cli-transaction-submit-new-output
branch
from
82c73e4
to
71bac0b
Compare
…it is a live utxo
smelc
force-pushed
the
smelc/test-cli-transaction-submit-new-output
branch
from
71bac0b
to
6311baf
Compare
smelc
added
need-update
next-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Needs IntersectMBO/cardano-cli#925
Description
Test this new additional output of
transaction submit: IntersectMBO/cardano-cli#925Checklist