[Evaluation] [Names] Define all lookups in terms of 'contIndexZero' #6702
+65
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
/benchmark validation |
|
/benchmark nofib |
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on 'efaadc5ce9' (base) and '40a378f84b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on 'efaadc5ce9' (base) and '40a378f84b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on 'efaadc5ce9' (base) and '40a378f84b' (PR) Results table
|
|
/benchmark nofib |
2 similar comments
|
/benchmark nofib |
|
/benchmark nofib |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on 'efaadc5ce9' (base) and '40a378f84b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on 'efaadc5ce9' (base) and '40a378f84b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on 'efaadc5ce9' (base) and '40a378f84b' (PR) Results table
|
|
/benchmark lists |
|
/benchmark nofib |
|
/benchmark validation |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on 'efaadc5ce' (base) and '40a378f84' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on 'efaadc5ce' (base) and '40a378f84' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on 'efaadc5ce' (base) and '40a378f84' (PR) Results table
|
effectfully
force-pushed
the
effectfully/evaluation/define-1-indexing-via-0-indexing
branch
from
40a378f
to
22bb3a2
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
commented
Nov 26, 2024
Comment on lines
186
to
156
| length Nil = 0 | ||
| length (BHead sz _ tl) = sz + RAL.length tl | ||
| {-# INLINABLE indexZero #-} | ||
| {-# INLINE uncons #-} | ||
|
|
||
| length = go 0 where | ||
| go acc Nil = acc | ||
| go acc (BHead sz _ tl) = go (acc + sz) tl |
There was a problem hiding this comment.
I don't know if it's important to make this one fast, but why not while we're here. It's more readable too, in my opinion.
| empty = Nil | ||
| {-# INLINABLE cons #-} | ||
| {-# INLINE empty #-} |
There was a problem hiding this comment.
We really want all of that to inline, no point is chickening out and saying INLINABLE.
| @@ -878,7 +878,7 @@ enterComputeCek = computeCek | |||
| -- | Look up a variable name in the environment. | |||
| lookupVarName :: NamedDeBruijn -> CekValEnv uni fun ann -> CekM uni fun s (CekValue uni fun ann) | |||
| lookupVarName varName@(NamedDeBruijn _ varIx) varEnv = | |||
| Env.safeIndexOneCont | |||
| Env.contIndexOne | |||
There was a problem hiding this comment.
This names better matches the other names in the module, should've gone with it originally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of 4 different implementation this will make it 1 main and 3 derivative ones.
This appears to make the
validationbenchmarks faster by a percent and thenofibbenchmarks faster by a couple of percent while simplifying the code, so a clear win.Please review this one VERY carefully.