Kwxm/conformance/fix data syntax #6720
Merged
+187
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwxm
commented
Nov 28, 2024
There was a problem hiding this comment.
I think GitHub is confused about what's happened here, but it's harmless.
effectfully
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the conformance tests involving
Dataused obsolete syntax and were failing with parse errors (which were in golden files, perhaps due to over-enthusiastic use of--accept). We must have forgotten to fix these when we introduced the final form of the concrete syntax: this fixes that.I also corrected a test name that didn't match its directory and added a few extra tests for the concrete syntax of other types.