Rewrote clearTeamInventory #848
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- should now correctly ignore visitors (since visitors are technically members?) - should now remove data for offline players
PeachesMLG
reviewed
May 13, 2024
|
|
||
| for(User user : island.getMembers()) { | ||
|
|
||
| if (user.getUserRank() == -1) continue; |
There was a problem hiding this comment.
I dont think this is needed, island.getMembers() only returns a list of the island members which doesnt include visitors
Comment on lines
+761
to
+766
| try{ | ||
| user.getPlayer(); | ||
| onlinePlayers.add(user); | ||
| } catch (Exception e) { | ||
| offlinePlayers.add(user); | ||
| } |
There was a problem hiding this comment.
Suggested change
| try{ | |
| user.getPlayer(); | |
| onlinePlayers.add(user); | |
| } catch (Exception e) { | |
| offlinePlayers.add(user); | |
| } | |
| Player player = user.getPlayer(); | |
| if (player == null){ | |
| offlinePlayers.add(player); | |
| } else { | |
| onlinePlayers.add(player); | |
| } |
Comment on lines
+774
to
+798
| for(User user : offlinePlayers) { | ||
|
|
||
| try { | ||
| File file = new File(Bukkit.getWorlds().get(0).getWorldFolder().getPath() + File.pathSeparator + "playerdata" + File.pathSeparator + user.getUuid() + ".dat"); | ||
| NBTFile playerFile = new NBTFile(file); | ||
|
|
||
| if (IridiumSkyblock.getInstance().getConfiguration().clearInventoryOnRegen) { | ||
| NBTCompound compound = playerFile.getCompound("").getCompound("Inventory"); | ||
| compound.clearNBT(); | ||
| playerFile.save(); | ||
| } | ||
|
|
||
| if (IridiumSkyblock.getInstance().getConfiguration().clearEnderChestOnRegen) { | ||
| NBTCompound compound = playerFile.getCompound("").getCompound("EnderItems"); | ||
| compound.clearNBT(); | ||
| playerFile.save(); | ||
| } | ||
|
|
||
| } catch (IOException e) { | ||
| IridiumSkyblock.getInstance().getLogger().warning("Cannot mutate user: " + user.getName() + ". See stacktrace for details."); | ||
| IridiumSkyblock.getInstance().getLogger().warning(e.getMessage()); | ||
| } catch (NullPointerException e) { | ||
| IridiumSkyblock.getInstance().getLogger().warning("Cannot mutate user: " + user.getName() + ". Either player or compound doesn't exist (See stacktrace for details)."); | ||
| IridiumSkyblock.getInstance().getLogger().warning(e.getMessage()); | ||
| } |
There was a problem hiding this comment.
I hate this... why cant you access an offline player's inventory (Talking to the physical embodiment of the Spigot API here, not you)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully fixes #847