Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong puny_encode with hyphen #110

Open
vandepitte opened this issue Feb 8, 2021 · 0 comments
Open

Wrong puny_encode with hyphen #110

vandepitte opened this issue Feb 8, 2021 · 0 comments

Comments

@vandepitte
Copy link

vandepitte commented Feb 8, 2021 •
edited
Loading

Version: urltools_1.7.3

Actual:

urltools::puny_encode('foo-bar.tld')
[1] "xn--foo-bar-.tld"

Expected:

urltools::puny_encode('foo-bar.tld')
[1] "foo-bar.tld"

Reason: foo-bar.tld only contains LDH labels and thus should not be converted to xn-- notation
@vandepitte vandepitte changed the title Wrong puny_encode with dash Wrong puny_encode with hyphen Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vandepitte