Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused abbrev dependency #268

Merged
merged 1 commit into from
Jan 20, 2024
Merged

remove unused abbrev dependency #268

merged 1 commit into from
Jan 20, 2024

Conversation

zvkemp
Copy link
Contributor

@zvkemp zvkemp commented Jan 18, 2024

It looks like the only usage of abbrev was removed in 9994c66.

@calebhearth
Copy link

FWIW, abbrev being around is causing errors that seem to be caused by Zeitwerk, but are actually coming from this gem:

/Users/caleb/.gem/ruby/2.6.10/gems/zeitwerk-2.6.12/lib/zeitwerk/kernel.rb:38: warning: abbrev was loaded from the standard library, but will no longer be part of the default gems since Ruby
 3.4.0. Add abbrev to your Gemfile or gemspec. Also contact author of zeitwerk-2.6.12 to add abbrev into its gemspec.    
❯ ag "require .abbrev." .gem                                                                                                                                          
.gem/ruby/3.3.0/gems/highline-2.1.0/lib/highline.rb                                                                                                                                          
17:require "abbrev"                                                                                                                                                                          
                                                                                                                                                                                             
.gem/ruby/3.2.2/gems/highline-2.1.0/lib/highline.rb                                                                                                                                          
17:require "abbrev"              

@abinoam
Copy link
Collaborator

abinoam commented Jan 20, 2024

Nice spot! Thank you very much both of you.
My bad for not checking its use before previous release.
I'll merge it and release it.

@abinoam abinoam merged commit 70d5567 into JEG2:master Jan 20, 2024
17 checks passed
@abinoam
Copy link
Collaborator

abinoam commented Jan 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants