libteec: Move OP-TEE defined fields into an imp struct

GlobalPlatform TEE Client API Specification v1.0 specifies that the structs TEEC_Context, TEEC_Session, TEEC_SharedMemory, and TEEC_Operation shall have a user defined struct named imp. In OP-TEE the struct is not there and instead the user defined fields are declared directly in the top structs. This commit introduces the imp struct to better support using different implementations. The imp fields now represent the implementation defined parts of the structs that was previously declared directly in the top struct. All previously available parameters are preserved in the imp struct. Adding the missing imp struct to the structs in OP-TEE is an ABI breakage which requires a version major update of libteec as explained by Jerome Forissier. Link: OP-TEE#348 Reported-by: Tom Hebb <[email protected]> Signed-off-by: Julianus Larson <[email protected]>
JLLinaro · Oct 27, 2023 · dbe8282 · dbe8282
1 parent 4c086f3
commit dbe8282
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/libteec/Makefile b/libteec/Makefile
@@ -9,7 +9,7 @@ all: libteec
 ################################################################################
 # Teec configuration
 ################################################################################
-MAJOR_VERSION	:= 1
+MAJOR_VERSION	:= 2
 MINOR_VERSION	:= 0
 PATCH_VERSION	:= 0
 LIB_NAME	:= libteec.so

diff --git a/public/tee_client_api.h b/public/tee_client_api.h
@@ -306,7 +306,7 @@ typedef struct {
 			bool dummy;
 			uint8_t flags;
 		} internal;
-    } imp;
+        } imp;
 } TEEC_SharedMemory;
 
 /**