Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Array Constructors/Accessors #346

Open
basdxz opened this issue Jun 26, 2024 · 1 comment
Open

Consistent Array Constructors/Accessors #346

basdxz opened this issue Jun 26, 2024 · 1 comment

Comments

@basdxz
Copy link

basdxz commented Jun 26, 2024

Would it be within scope to include consistent constructors/accessors in all existing types?

It's rather inconsistent which types can be created with an array of values. For example, vectors can be created using an array argument while matrices generally expect each value to be provided explicitly or from another matrix. On the other hand, matrices have getter methods which can output into a given array while vectors cannot.

Our team uses JOML extensively and I would be happy to PR said changes if this is something that would be accepted.

@zzuegg
Copy link

zzuegg commented Dec 11, 2024

Any updates? I would support this. Also Matrices cannot be build from a ByteBuffer while Vectors can. If wanted i can work on a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants