Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the function names in R/summarize.R #53

Closed
Seyi007 opened this issue Oct 6, 2024 · 1 comment · Fixed by #79
Closed

Replace the function names in R/summarize.R #53

Seyi007 opened this issue Oct 6, 2024 · 1 comment · Fixed by #79
Assignees
@jananiravi @teddyCodex @the-mayer
Labels
enhancement New feature or request outreachy for outreachy interns

Comments

@Seyi007
Copy link
Collaborator

Seyi007 commented Oct 6, 2024 •
edited
Loading 

          [R/summarize.R](https://github.com/JRaviLab/MolEvolvR/blob/main/R/summarize.R)
Original Modified User Facing
filter_by_doms filterByDomains
count_bycol countByColumn
elements2words elements2Words
find_paralogs findParalogs
words2wc words2WordCounts
filter_freq filterByFrequency
summarize_bylin summarizeByLineage
summ.DA.byLin summarizeDomainArch_ByLineage
summ.DA summarizeDomainArch
summ.GC.byDALin summarizeGenomicContext_ByDomainArchAndLineage
summ.GC.byLin summarizeGenomicContext_ByLineage
summ.GC summarizeGenomicContext
total_counts totalGenomicOrDomainArchitectureCounts

Originally posted by @the-mayer in #7 (comment)

All updates should follow this format:

Original Modified User Facing
original_function newFunction ✅

NOTE: Before beginning to work on a particular file, please check to see that @jananiravi has given the 👍 on the comment.

Please follow the contributing guidelines and create a new branch containing your changes. Commit your work, and submit a PR when ready for review.

Additionally, use the search in all files functionality in VS code, Rstudio, or any other text editor, and list all files the function is being called or used to be updated later.
@Seyi007 Seyi007 added enhancement New feature or request outreachy for outreachy interns labels Oct 6, 2024
@teddyCodex
Copy link
Collaborator

@jananiravi okay to go ahead with this?

@teddyCodex teddyCodex self-assigned this Oct 7, 2024
This was referenced Oct 7, 2024
Closed
Merged
@the-mayer the-mayer linked a pull request Oct 8, 2024 that will close this issue
Refactored function names in R/summarize.R #79
Merged
11 tasks
the-mayer added a commit to teddyCodex/MolEvolvR that referenced this issue Oct 8, 2024
@the-mayer
updates
490e542 
- adjust casing, RE JRaviLab#53
  - match with .Rd
- update references throughout MolEvolvR pkg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jananiravi jananiravi

@teddyCodex teddyCodex

@the-mayer the-mayer

Labels
enhancement New feature or request outreachy for outreachy interns
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored function names in R/summarize.R teddyCodex/MolEvolvR
4 participants
@jananiravi @teddyCodex @the-mayer @Seyi007