Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the function names in R/tree.R #54

Closed
Seyi007 opened this issue Oct 6, 2024 · 4 comments
Closed

Replace the function names in R/tree.R #54

Seyi007 opened this issue Oct 6, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request outreachy for outreachy interns

Comments

@Seyi007
Copy link
Collaborator

Seyi007 commented Oct 6, 2024

          [R/tree.R](https://github.com/JRaviLab/MolEvolvR/blob/main/R/tree.R)
Original Modified User Facing
convert_fa2tre convertFA2Tree
generate_trees convertAlignment2Trees
generate_fa2tre convertFA2Tree

Originally posted by @the-mayer in #7 (comment)

All updates should follow this format:

Original Modified User Facing
original_function newFunction

NOTE: Before beginning to work on a particular file, please check to see that @jananiravi has given the 👍 on the comment.

Please follow the contributing guidelines and create a new branch containing your changes. Commit your work, and submit a PR when ready for review.

Additionally, use the search in all files functionality in VS code, Rstudio, or any other text editor, and list all files the function is being called or used to be updated later.

@Seyi007 Seyi007 added enhancement New feature or request outreachy for outreachy interns labels Oct 6, 2024
@teddyCodex
Copy link
Collaborator

@jananiravi okay to go ahead with this?

@jananiravi
Copy link
Member

made minor modifications -- go ahead.

@teddyCodex
Copy link
Collaborator

teddyCodex commented Oct 7, 2024

@jananiravi You edit above has:

convert_fa2tre --> convertFA2Tree
generate_fa2tre --> convertFA2Tree

is this intentional?

note: using createFA2Tree pending your response.

@jananiravi
Copy link
Member

good catch -- intentional because they should have that name but creating duplicate names was not intentional! They both do the same thing (takes fasta sequences and generates trees, but use different algorithms -- that needs to be clarified. Also, I'm not sure which one is in use. Could you check, @the-mayer @epbrenner & recommend accordingly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request outreachy for outreachy interns
Projects
None yet
Development

No branches or pull requests

4 participants