Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to ROS2 #231

Open
mzahana opened this issue Feb 2, 2023 · 7 comments
Open

Migration to ROS2 #231

mzahana opened this issue Feb 2, 2023 · 7 comments

Comments

@mzahana
Copy link
Contributor

mzahana commented Feb 2, 2023

Hi @Jaeyoung-Lim

Any plans to make a version of this package for ROS2?

@Jaeyoung-Lim
Copy link
Owner

@mzahana What parts would you want on ros2?

@mzahana
Copy link
Contributor Author

mzahana commented Feb 2, 2023

I would imagine refactoring the geometric controller node, and any related nodes, to subscribe to ROS2 topics to get reference trajectory, and send setpoint to PX4.

I would not use MAVROS in this case since there is communication with PX4 through RTSP

@Jaeyoung-Lim
Copy link
Owner

@mzahana Any updates regarding this matter? I think it would take me max. 1 day to port this over if it is useful for anyone

@mzahana
Copy link
Contributor Author

mzahana commented Aug 8, 2023

It is definitely in the plan. I just have not had the time to work on it. Maybe I will get some time in a week or 2.

@Jaeyoung-Lim
Copy link
Owner

@mzahana We can try to work together to also get it done more quickly.

I have most parts without the controller done here: https://github.com/Jaeyoung-Lim/px4-offboard

@mzahana
Copy link
Contributor Author

mzahana commented Aug 25, 2023

I saw your repo for the offboard controller in ros2.

Are you thinking of a c++ implementation or Python one ?
You use the Eigen library, and we would need to go C++ to have minimum migration time, compared to Python.

Also, I have a concern about the name of the package. If it is mostly a geometric controller, and mavros is not yet mature for ros2 integration, why would it be called mavros_controllers ?

I would explicitly call it something like geometric_controller_ros2, or something similar.

@ZhongmouLi
Copy link

I am interested in this topic, especially c++ version of mavros controller. But I am just beginning ros2. Let me see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants