Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Do no discover abstract CommandHandler classes #9

Open
MarkusBernhardt opened this issue Jul 10, 2019 · 0 comments
Open

Request: Do no discover abstract CommandHandler classes #9

MarkusBernhardt opened this issue Jul 10, 2019 · 0 comments

Comments

@MarkusBernhardt
Copy link

Could you please add the condition !x.IsAbstract() in CommandRegistry:

    public ICommandRegistry Discover(params Assembly[] assemblies)
        {
            Type commandHandlerBase = typeof(ICommandHandlerBase);
            foreach (Assembly assembly in assemblies)
            {
                Type[] handlers = assembly.GetTypes().Where(x => !x.IsAbstract() && commandHandlerBase.IsAssignableFrom(x)).ToArray();
                foreach (Type handler in handlers)
                {
                    Register(handler);
                }
            }
            return this;
        }

I'm using some abstract CommandHandler base classes with unspecified generic parameters that will crash FunctionMonkey when registered to the CommandRegistry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant