Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of contents (toc) does not show #75

Open
enryH opened this issue Feb 12, 2024 · 7 comments
Open

Table of contents (toc) does not show #75

enryH opened this issue Feb 12, 2024 · 7 comments

Comments

@enryH
Copy link

enryH commented Feb 12, 2024

I tried you example notebook with interactive components. If I import itables, then the toc is not extended/visable. Any idea why this happens?

If I test it with your interactive example notebook, it works when I do not re-execute the notebook, but it fails when I do re-execute it. Any idea which other package could cause the trouble?

# Name                    Version                   Build  Channel
itables                   1.7.0                    pypi_0    pypi
pretty-jupyter            2.0.5                    pypi_0    pypi
@JanPalasek
Copy link
Owner

Hello, thanks for reporting the issue. Ill look at it asap.

@JanPalasek
Copy link
Owner

@enryH If you can, I suggest to downgrade itables to 1.6.4 for now. This problem is in long-dead jquery plugin tocify and it's gonna be hard to fix.

@enryH
Copy link
Author

enryH commented Feb 18, 2024

Hey! I can:) And I tried it - works as intended. I am unfortunately not a JS programmer (although I had contact to TypeScript...). I hope there is a way to replace `tocify in the future...

I tried to see what change between version 1.6.4 and 1.7.0, but the tags and pip release do not correspond somehow...

Thanks for looking into this!

@JanPalasek
Copy link
Owner

Glad it worked!

Maybe tempering with the following few lines will fix the issue:

<!-- hotfix to support interactive tables package -->

I will look into that.

@JanPalasek
Copy link
Owner

The problem is that itables creates loads its own jQuery and overrides the jQuery that tocify uses. I used to be able to detect that and fix it with the specified code, but after the new version the detection does not seem to work.

@JanPalasek
Copy link
Owner

Fixed TOC for itables of version 1.7.0. Ain't pretty, but it will work.

JanPalasek added a commit that referenced this issue Feb 23, 2024
@JanPalasek
Copy link
Owner

Unfortunately, the fix didn't work. Reopening.

@JanPalasek JanPalasek reopened this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants