Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe config file will fail if no semicolon at end #107

Open
sppmg opened this issue Apr 1, 2019 · 1 comment
Open

Probe config file will fail if no semicolon at end #107

sppmg opened this issue Apr 1, 2019 · 1 comment
Assignees
Labels

Comments

@sppmg
Copy link

sppmg commented Apr 1, 2019

Output of ver

all

Output of gpuDevice

all

The command you used

(e.g., jrc detect-sort myparam.prm)
jrc bootstrap

If manually sorting, what it is you tried to do

Console output


Hi

I'm try JRCLUST-4.0.0-beta, but discover a little problem.

When probe config file(*.prb) not end by semicolon, it will get error.

Error using loadProbe (line 11)
missing `channels` field

Error in jrclust.Config/loadParams (line 78)
        probe = loadProbe(pf);

Error in jrclust.Config (line 86)
            obj.loadParams(userParams);

Error in JRC/bootstrap (line 128)
    hCfg_ = jrclust.Config(cfgData);

Error in JRC/processArgs (line 128)
            obj.bootstrap(obj.args{:});

Error in JRC (line 54)
                    obj.processArgs();

Error in jrc (line 16)
    hJRC = JRC(varargin{:});

It cause by JRCLUST-4.0.0-beta/+jrclust/+utils/mToStruct.m Line 12

eval(cell2mat(lines'));

e.g. If below in prb

geometry(1:end,1) = 0 
geometry(1:end,2) = 100*[0:31] 

cell2mat(lines') will output below string, so error.

geometry(1:end,1) = 0 geometry(1:end,2) = 100*[0:31] 

Suggest instead of eval(strjoin(lines,';')) to insert semicolon.
(Note: strjoin introduced in R2016b)

Thanks.

@aliddell
Copy link
Collaborator

aliddell commented Apr 2, 2019

Nice catch, but your solution won't quite work, since, e.g., a semicolon would break an if statement. For the time being just add the semicolons and I'll push a fix in the near future.

@aliddell aliddell self-assigned this Apr 2, 2019
@aliddell aliddell added the bug label Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants