Fix duplicate player hrefs in FBref functions #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyelhabr
commented
Sep 25, 2023
| @@ -48,7 +48,7 @@ | |||
| return(tibble::tibble()) | |||
| } | |||
| renamed_table <- .rename_fb_cols(tables[[3]]) | |||
| renamed_table[renamed_table$Rk != "Rk", ] | |||
There was a problem hiding this comment.
drive by fix... this should have been assigned back to renamed_table 😅
tonyelhabr
commented
Sep 25, 2023
R/get_advanced_match_stats.R
Outdated
| res <- dplyr::mutate( | ||
| df, | ||
| "Player_Href" = players[df$Player], | ||
| "Player_Href" = player_hrefs, |
There was a problem hiding this comment.
this assumes the number of player links will be equal to the number of rows in df. this is probably a fine assumption
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #332 +/- ##
==========================================
- Coverage 63.18% 63.09% -0.10%
==========================================
Files 44 44
Lines 3583 3582 -1
==========================================
- Hits 2264 2260 -4
- Misses 1319 1322 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible for FBref functions that returned
Player_Href(added with #328) to return "bad" links when there are different players with the same exact name. This is fixed by simply joining the hrefs back to the rest of the dataframe rather than doing a lookup by name. The new approach may encounter an error if a player does not have an FBref page for some reason, although I've never actually seen that before.Fixes #327.