Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutable Query objects #52

Open
JanHolger opened this issue Sep 8, 2023 · 1 comment
Open

Immutable Query objects #52

JanHolger opened this issue Sep 8, 2023 · 1 comment
Assignees
@JanHolger
Labels
enhancement New feature or request

Comments

@JanHolger
Copy link
Member

Is your feature request related to a problem? Please describe.
Right now the Query and QueryGroup classes are built in a builder pattern style way (mutating their own object and returning this). This has a couple advantages but also comes with several disadvantages and I would generally say that it is bad practice.

Describe the solution you'd like
Since completely changing them to immutable may break existing code and may not be in favor of all users, I would rather add a new .mutable() and .immutable() switch and a default state for new queries in the config.
@JanHolger JanHolger added the enhancement New feature or request label Sep 8, 2023
@JanHolger
Copy link
Member Author

working on this in #53

@JanHolger JanHolger self-assigned this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JanHolger JanHolger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JanHolger