Create Share and GetConnected apps #622
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalamav
reviewed
Apr 27, 2020
| export class GetConnectedApp { | ||
| constructor(private dialog: polymer.Base) { | ||
| // Get connected is not a Polymer component, so we use `querySelector()` instead of `dialog.$`. | ||
| dialog.querySelector('#closeGetConnectedButton') |
There was a problem hiding this comment.
getConnectedDialog is a paper-dialog and you're passing a polymer.Base object, so it's not clear to me why dialog is not a Polymer component.
| @@ -145,6 +147,9 @@ export class App { | |||
| private digitalOceanTokenManager: TokenManager, private surveys: Surveys) { | |||
| appRoot.setAttribute('outline-version', this.version); | |||
|
|
|||
| const shareApp = new ShareDialogApp(appRoot.$.shareDialog); | |||
| const getConnectedApp = new GetConnectedApp(appRoot.$.getConnectedDialog); | |||
There was a problem hiding this comment.
nit: s/App/Controller. I think app is not as intuitive to understand the relationship of the class with the view element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes progress and is an example of:
The impact of this change is not huge, but we will see a much bigger impact if we use a similar pattern in larger components, like the server view.
cc: @JonathanDCohen @mpmcroy