Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PR Action #265

Open
Jikoo opened this issue Dec 14, 2024 · 0 comments
Open

Improve PR Action #265

Jikoo opened this issue Dec 14, 2024 · 0 comments

Comments

@Jikoo
Copy link
Owner

Jikoo commented Dec 14, 2024

PR action always builds Maven project even if only resource pack is affected.
PR action never builds resource pack.

PR action should build Maven project unless only resource pack files are modified. This should include all prior changes so a successful resource pack build doesn't give a misleading green check to a failing Maven build. We may need to grab more git history to determine that (I believe we use a shallow clone for speed); I'm unsure if GitHub checks only the current commit or all changes when using paths/paths-ignore.
PR action should build resource pack if resource pack or actions are modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant