Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this repo still active? No commits in the last 18 months + lots of open PRs #182

Closed
jeznag opened this issue Dec 16, 2020 · 9 comments
Closed

Comments

@jeznag
Copy link

jeznag commented Dec 16, 2020

I can see there's a few forks including https://github.com/kybarg/react-qr-scanner#readme

Any suggested forks?

@wesbos
Copy link

wesbos commented Jan 1, 2021

Looks like this one is being maintained https://github.com/kybarg/react-qr-scanner

@KhaosArbiter
Copy link

KhaosArbiter commented Feb 5, 2021

The above fork seems to have multiple issues with it as well, and the maintainer has said in several locations that for some reason, it's going to be targeting desktop? In light of this, I've forked this as well and will gladly help bring this up to par as my first real work on a public repo. If anyone wishes to see about getting their existing pull requests over to the below repo, feel free to reach out to me. It seems like even in it's current state this is still a very good base for a super simple QR Reader implementation for react based projects, and it would be a shame to just let this die, or squander in non-active or private repo forks.

https://github.com/KhaosArbiter/modern-react-qr-reader

@JonatanSalas
Copy link
Contributor

JonatanSalas commented Jun 22, 2021

We've based our code in this library but then ported everything to use Zxing under the hood which is really better than JsQR.

The repo is here: https://github.com/BlackBoxVision/react-qr-reader

We're actively mantaining the library.

@phuhl
Copy link

phuhl commented Jun 23, 2021

Hi @JonatanSalas, thanks for taking over. Are there any plans to migrate to react 17 on your fork?

Cheers

@JonatanSalas
Copy link
Contributor

Yes, we've intended support for react 17, if you want you can open a discussion on the repo so we can talk about all the things that needs to be done in order to support it.

@krigez
Copy link

krigez commented Nov 13, 2021

yes there is a PR which is working and most of the people have found a workaround.
#192

But the above mentioned react-qr-reader by " @wesbos" has duplicate dependencies, which is not good. better avoid for dependencies.

@JonatanSalas
Copy link
Contributor

@chaitanyaarige at https://github.com/BlackBoxVision/react-qr-reader we've added support for React v17.

@krigez
Copy link

krigez commented Feb 4, 2022

Thanks a lot for your good work

@JodusNodus
Copy link
Owner

Working on the new release thanks to the work of @JonatanSalas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants