Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid_points improvements #27

Open
ryanlevy opened this issue May 8, 2024 · 1 comment
Open

grid_points improvements #27

ryanlevy opened this issue May 8, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@ryanlevy
Copy link
Collaborator

ryanlevy commented May 8, 2024

For certain values, grid_points will not get close to the value of 1.
For example, 50 grid points on L=6 will result with a max of 0.796875

image

Also a wishlist, it would nice to enforce a certain point (like I want a grid but make sure 0.5 is there)

@JoeyT1994
Copy link
Owner

Yeah I think the grid_points functionality should be massively fleshed out

To add to the wishlist we should also be able to sample randomly from the grid. For instance we could overload rand so that
Random.rand(s::IndexMap) randomly chooses a point on the d-dimensional grid defined by IndexMap

@ryanlevy ryanlevy added the good first issue Good for newcomers label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants