Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): calldatacopy argument heuristics #440

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

iankressin
Copy link
Contributor

Motivation

Targets #379

Solution

@iankressin iankressin changed the title feat(utls): calldatacopy argument heuristics feat(utils): calldatacopy argument heuristics Jun 11, 2024
@Jon-Becker Jon-Becker linked an issue Jun 12, 2024 that may be closed by this pull request
@iankressin iankressin marked this pull request as ready for review June 21, 2024 20:22
Copy link
Owner

@Jon-Becker Jon-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally got a chance to take a look, looks pretty good overall! there is a bit more needed to the implementation i think, since decompiling seaport 0x00000000000000adc04c56bf30ac9d3c0aaf14dc gives a lot of nonsense (most functions end up having like 20 args D:)

i think calculating arg_index needs to change for both CALLDATALOAD and CALLDATACOPY with a more sophisticated mapping calculation, since CALLDATACOPY can span multiple words and this will throw the calculations off

i'll probably add a few commits trying to address this soonish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement CALLDATACOPY support
2 participants