Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting errors at compile time Member access into incomplete type 'reactjuce::EcmascriptEngine::Pimpl' #283

Open
duro opened this issue Nov 18, 2021 · 4 comments

Comments

@duro
Copy link

duro commented Nov 18, 2021

I posted this in the Discord, so forgive me if this is redundant.

I am trying to get a simple HelloWorld app going. I have the JS bundle built, but when I compile the plugin in XCode I get the following error all over the place:

Member access into incomplete type 'reactjuce::EcmascriptEngine::Pimpl'

Here is a Gist of the only two files in the JUCE C++ app:
https://gist.github.com/duro/b5cca6caf1aa4fb9b735bf59596d7c85#file-pluginprocessor-cpp-L166

@shudza
Copy link

shudza commented Nov 18, 2021

I've fixed it by adding REACTJUCE_USE_DUKTAPE=1 to "Preprocessor definitions" in Projucer. No docs on that one. Also, REACTJUCE_USE_HERMES=1 doesn't seem to work.

@nick-thompson
Copy link
Collaborator

nick-thompson commented Nov 19, 2021

I've fixed it by adding REACTJUCE_USE_DUKTAPE=1 to "Preprocessor definitions" in Projucer. No docs on that one. Also, REACTJUCE_USE_HERMES=1 doesn't seem to work.

Yep, that's exactly the fix (for now). This is an issue we intend to fix asap! Thanks @milan-markovic for your quick answer

@shudza
Copy link

shudza commented Nov 19, 2021

@nick-thompson can you check why hermes isn't working?

@nick-thompson
Copy link
Collaborator

Of course, yea. I'm also going to ping @JoshMarler on this one as he's more knowledgeable on the details of the hermes integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants