Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to use newer version of Substrate #4918

Closed
mnaamani opened this issue Oct 9, 2023 · 2 comments
Closed

Bump to use newer version of Substrate #4918

mnaamani opened this issue Oct 9, 2023 · 2 comments
Assignees

Comments

@mnaamani
Copy link
Member

mnaamani commented Oct 9, 2023

Do we need this?

paritytech/substrate#13630

┆Issue is synchronized with this Asana task by Unito

@mnaamani mnaamani self-assigned this Oct 9, 2023
@bedeho bedeho changed the title Maybe bump trie-db Bump to use slightly newer version of Substrate (0.9.39-1) Oct 9, 2023
@mnaamani
Copy link
Member Author

mnaamani commented Oct 9, 2023

The next polkadot substrate release which contains the updated trie-db v0.27.1 is v0.9.42 https://github.com/paritytech/polkadot/releases/tag/v0.9.42

@mnaamani mnaamani changed the title Bump to use slightly newer version of Substrate (0.9.39-1) Bump to use newer version of Substrate (0.9.42) Oct 10, 2023
@mnaamani mnaamani changed the title Bump to use newer version of Substrate (0.9.42) Bump to use newer version of Substrate Oct 16, 2023
@mnaamani
Copy link
Member Author

After reviewing the changes in releases here: https://forum.polkadot.network/tag/release-analysis

I determined that the best version to update to at this time is 0.9.41 and manually bumping the trie-db to v0.27.1

I was tempted to just go straight to 0.9.43 even (current polkadot network release), however there are some high impact changes to the balances pallet. paritytech/substrate#12951 which we would need to understand better to make sure it doesn't break any of the assumptions we make about joystream's staking mechanism with respect to reserved balances/locks and existential deposits.

So our forked version is at https://github.com/Joystream/substrate/commits/joystream-polkadot-v0.9.41-update
built on-top of https://github.com/paritytech/substrate/tree/polkadot-v0.9.41 - compare the diff Joystream/substrate@polkadot-v0.9.41...Joystream:substrate:joystream-polkadot-v0.9.41-update

This includes a fix for the staking pallet migration which removes a wrong post runtime upgrade migration assertion.

Implemented in #4932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant