-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with Images.jl? #18
Comments
I think the main reason is that there are not yet any Julia astro packages for actually doing anything with images. So, no one has really worried about a type for conveniently representing astronomical images in memory (beyond simple arrays), or about the image operations that Images.jl provides. I did a little exploratory work on a package to actually do some analysis on images and I mean to get back to it at some point. I think any such package will want to be compatible with Image.jl's AbstractImage type so that it can take advantage of any astro-relevant functionality in Images.jl. (At a quick glance, the "filtering" functions are something that would definitely be relevant.) When I get back to that, I'll be sure to look closely at the Image types and ping you if there's anything missing (from an optical/near-IR astro perspective anyway). Thanks for the pointer to the Images.jl I/O infrastructure; I wasn't aware of it. Is the idea that this could be a sub-module of Images so that FITSIO would only be used if installed? E.g. using Images
using Images.FITS
img = imread("filename.fits") |
Even easier (from a user perspective): using Images
img = imread("filename.fits") The extension alone (or even better, a magic number in the file if FITS files have one) would be enough to trigger loading of FITSIO via a short wrapper. |
One thing I should point out is that I'm wondering if you folks might need enhancements to |
Ah, yes. There's a couple things about FITS to note:
|
I'm not surprised to hear it could be complicated. It's possible that integrating with Another thing that I imagine astronomers might want would be some extensions to |
I've just created the package I think the discussion should continue to JuliaAstro/AstroImages.jl#1 |
I notice there's no integration with Images.jl here, and I'm curious about the reasons. If Images.jl doesn't actually offer anything of value to you, what would it take to make it useful? (I'm not saying I expect that it already has every algorithm you'd ever need, but I'd be equally surprised if there's nothing of value---if so, that's clearly a deficiency in Images.jl.) If Images.jl's I/O architecture isn't compatible with your needs, again it would be interesting to know what would need to be done to make it work. Images.jl is currently being used by the computer-vision and biomedical imaging folks, but I'm not aware of any astronomy people, and it would be great to make sure your needs are also met.
For I/O integration, see docs here:
https://github.com/timholy/Images.jl/blob/master/doc/extendingIO.md
The hope would be that a couple of stub functions in a file starting with
using FITSIO
would allow easy integration. If you need more sophisticated control over I/O than Images currently offers, well, that would be something we could talk about.The text was updated successfully, but these errors were encountered: