bugfix broadcasting 380 (#382)

JuliaData · Mar 1, 2024 · 28bfa4d · 28bfa4d
1 parent 85f104b
commit 28bfa4d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/parsing_astable.jl b/src/parsing_astable.jl
@@ -21,6 +21,7 @@ function replace_syms_astable!(inputs_to_function::AbstractDict,
         return e.args[2]
     end
 
+    println(e)
     col = get_column_expr(e)
     if col !== nothing
         return conditionally_add_symbols!(inputs_to_function, lhs_assignments, col)
@@ -35,7 +36,7 @@ protect_replace_syms_astable!(inputs_to_function::AbstractDict,
                               lhs_assignments::OrderedCollections.OrderedDict, e) = e
 protect_replace_syms_astable!(inputs_to_function::AbstractDict,
                               lhs_assignments::OrderedCollections.OrderedDict, e::Expr) =
-    replace_syms!(inputs_to_function, lhs_assignments, e)
+    replace_syms_astable!(inputs_to_function, lhs_assignments, e)
 
 function replace_dotted_astable!(inputs_to_function::AbstractDict,
                                  lhs_assignments::OrderedCollections.OrderedDict, e)

diff --git a/test/astable_flag.jl b/test/astable_flag.jl
@@ -213,4 +213,18 @@ end
     @test_throws ArgumentError @eval @transform df @astable cols(AsTable) = :y
 end
 
+@testset "Broadcasting bugfix #380" begin
+    df = DataFrame(x=["a","b"], y = [1, 2], z = [3, 4])
+    @transform df @astable :a = string.(:x, "c")
+    @transform df @astable :a = :y .+ :z
+    @transform df @astable :a = (+).(:y, :z)
+    @select df @astable begin
+        :a = string.(:x, "c")
+        :b = string.(:x, :y)
+        :c = string.(:x, $"y")
+        :d = :y .+ :z
+        :e = (+).(:y, :z)
+    end
+end
+
 end # module